diff options
author | Markus Roberts <Markus@reality.com> | 2010-07-09 18:07:15 -0700 |
---|---|---|
committer | Markus Roberts <Markus@reality.com> | 2010-07-09 18:07:15 -0700 |
commit | 543225970225de5697734bfaf0a6eee996802c04 (patch) | |
tree | ecc6f639c43cf1812e64f9c6ce7eacc0922b57ff /lib/puppet/resource | |
parent | 8f15707251cdb58d53e82c4bbd332a38c2d31b4c (diff) | |
download | puppet-543225970225de5697734bfaf0a6eee996802c04.tar.gz puppet-543225970225de5697734bfaf0a6eee996802c04.tar.xz puppet-543225970225de5697734bfaf0a6eee996802c04.zip |
Code smell: Avoid needless decorations
* Replaced 704 occurances of (.*)\b([a-z_]+)\(\) with \1\2
3 Examples:
The code:
ctx = OpenSSL::SSL::SSLContext.new()
becomes:
ctx = OpenSSL::SSL::SSLContext.new
The code:
skip()
becomes:
skip
The code:
path = tempfile()
becomes:
path = tempfile
* Replaced 31 occurances of ^( *)end *#.* with \1end
3 Examples:
The code:
becomes:
The code:
end # Dir.foreach
becomes:
end
The code:
end # def
becomes:
end
Diffstat (limited to 'lib/puppet/resource')
-rw-r--r-- | lib/puppet/resource/catalog.rb | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/puppet/resource/catalog.rb b/lib/puppet/resource/catalog.rb index b5f173718..79888529f 100644 --- a/lib/puppet/resource/catalog.rb +++ b/lib/puppet/resource/catalog.rb @@ -129,7 +129,7 @@ class Puppet::Resource::Catalog < Puppet::SimpleGraph # Expire all of the resource data -- this ensures that all # data we're operating against is entirely current. - expire() + expire Puppet::Util::Storage.load if host_config? transaction = Puppet::Transaction.new(self) @@ -159,7 +159,7 @@ class Puppet::Resource::Catalog < Puppet::SimpleGraph return transaction ensure @applying = false - cleanup() + cleanup end # Are we in the middle of applying the catalog? @@ -283,7 +283,7 @@ class Puppet::Resource::Catalog < Puppet::SimpleGraph if block_given? yield(self) - finalize() + finalize end end @@ -497,7 +497,7 @@ class Puppet::Resource::Catalog < Puppet::SimpleGraph def cleanup # Expire any cached data the resources are keeping. - expire() + expire end # Verify that the given resource isn't defined elsewhere. |