Code smell: Don't restate results directly after assignment

Replaced 33 occurances of

        ([$@]?\w+)( +[|&+-]{0,2}= .+)
        \1
    end

with

3 Examples:

    The code:
            @sync ||= Sync.new
            @sync
        end
    becomes:
            @sync ||= Sync.new
        end
    The code:
            str += "\n"
            str
        end
    becomes:
            str += "\n"
        end
    The code:
            @indirection = Puppet::Indirector::Indirection.new(self, indirection,  options)
            @indirection
        end
    becomes:
            @indirection = Puppet::Indirector::Indirection.new(self, indirection,  options)
        end

1 files changed, 0 insertions, 1 deletions

diff --git a/lib/puppet/reports/rrdgraph.rb b/lib/puppet/reports/rrdgraph.rb
index c93f13e02..b152faaab 100644
--- a/lib/puppet/reports/rrdgraph.rb
+++ b/lib/puppet/reports/rrdgraph.rb
@@ -23,7 +23,6 @@ Puppet::Reports.register_report(:rrdgraph) do
 
     def hostdir
         @hostdir ||= File.join(Puppet[:rrddir], self.host)
-        @hostdir
     end
 
     def htmlfile(type, graphs, field)