Refactoring how the catalog creation handles errors.

Previously, if there were an error creating a resource,
the error would propagate leaving any previously
created resources still in memory.

Now, resources are removed by default when an error
happens during instantiation, and the error propagates
to the caller so that they can log or whatever.

This also allows the Settings class to correctly and
separately handle the cases where we can't create the
catalog (which should never happen in normal usage but
was happening because of this error -- later catalogs
couldn't be created because earlier catalogs left
resources lying around) from those where we can't
apply the catalog.

0 files changed, 0 insertions, 0 deletions