diff options
| author | Markus Roberts <Markus@reality.com> | 2010-07-09 18:01:33 -0700 |
|---|---|---|
| committer | Markus Roberts <Markus@reality.com> | 2010-07-09 18:01:33 -0700 |
| commit | 77f8599f55be12bf5c7d69ac8f439d1fd756eafc (patch) | |
| tree | e8db2af5836d6fb4e3061531d570ffd24a087373 /lib/puppet/provider | |
| parent | 3fbc1d57f07598de225ac805ff000733480c9ff8 (diff) | |
Code smell: Win32 --> MS_windows
* Replaced 12 occurances of Win32 with Microsoft Windows
3 Examples:
The code:
# and all .rb files in lib/. This is disabled by default on Win32.
becomes:
# and all .rb files in lib/. This is disabled by default on Microsoft Windows.
The code:
# We can use Win32 functions
becomes:
# We can use Microsoft Windows functions
The code:
desc "Uses Win32 functionality to manage file's users and rights."
becomes:
desc "Uses Microsoft Windows functionality to manage file's users and rights."
* Replaced 10 occurances of :win32 with :microsoft_windows
3 Examples:
The code:
Puppet.features.add(:win32, :libs => ["sys/admin", "win32/process", "win32/dir"])
becomes:
Puppet.features.add(:microsoft_windows, :libs => ["sys/admin", "win32/process", "win32/dir"])
The code:
Puppet::Type.type(:file).provide :win32 do
becomes:
Puppet::Type.type(:file).provide :microsoft_windows do
The code:
confine :feature => :win32
becomes:
confine :feature => :microsoft_windows
* Replaced 13 occurances of win32\? with microsoft_windows?
3 Examples:
The code:
signals.update({:HUP => :restart, :USR1 => :reload, :USR2 => :reopen_logs }) unless Puppet.features.win32?
becomes:
signals.update({:HUP => :restart, :USR1 => :reload, :USR2 => :reopen_logs }) unless Puppet.features.microsoft_windows?
The code:
raise Puppet::Error,"Cannot determine basic system flavour" unless Puppet.features.posix? or Puppet.features.win32?
becomes:
raise Puppet::Error,"Cannot determine basic system flavour" unless Puppet.features.posix? or Puppet.features.microsoft_windows?
The code:
require 'sys/admin' if Puppet.features.win32?
becomes:
require 'sys/admin' if Puppet.features.microsoft_windows?
Diffstat (limited to 'lib/puppet/provider')
| -rw-r--r-- | lib/puppet/provider/file/win32.rb | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/puppet/provider/file/win32.rb b/lib/puppet/provider/file/win32.rb index b19bd0c5a..21cc2deff 100644 --- a/lib/puppet/provider/file/win32.rb +++ b/lib/puppet/provider/file/win32.rb @@ -1,11 +1,11 @@ -Puppet::Type.type(:file).provide :win32 do - desc "Uses Win32 functionality to manage file's users and rights." +Puppet::Type.type(:file).provide :microsoft_windows do + desc "Uses Microsoft Windows functionality to manage file's users and rights." - confine :feature => :win32 + confine :feature => :microsoft_windows include Puppet::Util::Warnings - require 'sys/admin' if Puppet.features.win32? + require 'sys/admin' if Puppet.features.microsoft_windows? def id2name(id) return id.to_s if id.is_a?(Symbol) |
