diff options
author | Markus Roberts <Markus@reality.com> | 2010-07-09 18:06:48 -0700 |
---|---|---|
committer | Markus Roberts <Markus@reality.com> | 2010-07-09 18:06:48 -0700 |
commit | 42a539061293f8e745a9dc5b97b4415b6a275e04 (patch) | |
tree | fb268244b7ca95dd36e8136bcd3c02fd2a05632f /lib/puppet/provider/macauthorization | |
parent | a07bbe2e711ee22a40e147c046997c8813ae3cc8 (diff) | |
download | puppet-42a539061293f8e745a9dc5b97b4415b6a275e04.tar.gz puppet-42a539061293f8e745a9dc5b97b4415b6a275e04.tar.xz puppet-42a539061293f8e745a9dc5b97b4415b6a275e04.zip |
Code smell: Use ||= for conditional initialization
Replaced 55 occurances of
([$@]?\w+) += +(.*) +(if +\1.nil\?|if +! *\1|unless +\1|unless +defined\?\(\1\))$
with
\1 ||= \2
3 Examples:
The code:
@sync
becomes:
@sync
The code:
becomes:
The code:
if @yydebug
becomes:
if @yydebug
Diffstat (limited to 'lib/puppet/provider/macauthorization')
-rw-r--r-- | lib/puppet/provider/macauthorization/macauthorization.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/puppet/provider/macauthorization/macauthorization.rb b/lib/puppet/provider/macauthorization/macauthorization.rb index 22186de42..4c55d7280 100644 --- a/lib/puppet/provider/macauthorization/macauthorization.rb +++ b/lib/puppet/provider/macauthorization/macauthorization.rb @@ -157,7 +157,7 @@ Puppet::Type.type(:macauthorization).provide :macauthorization, :parent => Puppe cmds << :security << "authorizationdb" << "read" << resource[:name] output = execute(cmds, :combine => false) current_values = Plist::parse_xml(output) - current_values = {} if current_values.nil? + current_values ||= {} specified_values = convert_plist_to_native_attributes(@property_hash) # take the current values, merge the specified values to obtain a |