diff options
author | Markus Roberts <Markus@reality.com> | 2010-07-09 18:06:33 -0700 |
---|---|---|
committer | Markus Roberts <Markus@reality.com> | 2010-07-09 18:06:33 -0700 |
commit | 8d1fbe4586c91682cdda0cb271649e918fd9778b (patch) | |
tree | 314508ca21830874d9e4ec6e27880fede14193bd /lib/puppet/property.rb | |
parent | 889158ad57e33df083613d6f7d136b2e11aaa16a (diff) | |
download | puppet-8d1fbe4586c91682cdda0cb271649e918fd9778b.tar.gz puppet-8d1fbe4586c91682cdda0cb271649e918fd9778b.tar.xz puppet-8d1fbe4586c91682cdda0cb271649e918fd9778b.zip |
Code smell: Avoid explicit returns
Replaced 583 occurances of
(DEF)
(LINES)
return (.*)
end
with
3 Examples:
The code:
def consolidate_failures(failed)
filters = Hash.new { |h,k| h[k] = [] }
failed.each do |spec, failed_trace|
if f = test_files_for(failed).find { |f| failed_trace =~ Regexp.new(f) }
filters[f] << spec
break
end
end
return filters
end
becomes:
def consolidate_failures(failed)
filters = Hash.new { |h,k| h[k] = [] }
failed.each do |spec, failed_trace|
if f = test_files_for(failed).find { |f| failed_trace =~ Regexp.new(f) }
filters[f] << spec
break
end
end
filters
end
The code:
def retrieve
return_value = super
return_value = return_value[0] if return_value && return_value.is_a?(Array)
return return_value
end
becomes:
def retrieve
return_value = super
return_value = return_value[0] if return_value && return_value.is_a?(Array)
return_value
end
The code:
def fake_fstab
os = Facter['operatingsystem']
if os == "Solaris"
name = "solaris.fstab"
elsif os == "FreeBSD"
name = "freebsd.fstab"
else
# Catchall for other fstabs
name = "linux.fstab"
end
oldpath = @provider_class.default_target
return fakefile(File::join("data/types/mount", name))
end
becomes:
def fake_fstab
os = Facter['operatingsystem']
if os == "Solaris"
name = "solaris.fstab"
elsif os == "FreeBSD"
name = "freebsd.fstab"
else
# Catchall for other fstabs
name = "linux.fstab"
end
oldpath = @provider_class.default_target
fakefile(File::join("data/types/mount", name))
end
Diffstat (limited to 'lib/puppet/property.rb')
-rw-r--r-- | lib/puppet/property.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/puppet/property.rb b/lib/puppet/property.rb index e8aeec053..ec700fbdf 100644 --- a/lib/puppet/property.rb +++ b/lib/puppet/property.rb @@ -169,7 +169,7 @@ class Puppet::Property < Puppet::Parameter @should.each { |val| return true if is == val or is == val.to_s } # otherwise, return false - return false + false end # because the @should and @is vars might be in weird formats, @@ -209,7 +209,7 @@ class Puppet::Property < Puppet::Parameter # this implicitly means that a given object can only have one property # instance of a given property class def name - return self.class.name + self.class.name end # for testing whether we should actually do anything |