Fix for #3558 -- source file reading speedup

It's about 10x faster to read the whole file than to read each line and
concatenate them (actually, it's O(n) vs. O(n^2), so the exact speedup
depends on the file size).

1 files changed, 1 insertions, 7 deletions

diff --git a/lib/puppet/parser/lexer.rb b/lib/puppet/parser/lexer.rb
index 2a1f88e44..f13a85f35 100644
--- a/lib/puppet/parser/lexer.rb
+++ b/lib/puppet/parser/lexer.rb
@@ -286,16 +286,10 @@ class Puppet::Parser::Lexer
         return array
     end
 
-    # this is probably pretty damned inefficient...
-    # it'd be nice not to have to load the whole file first...
     def file=(file)
         @file = file
         @line = 1
-        File.open(file) { |of|
-            str = ""
-            of.each { |line| str += line }
-            @scanner = StringScanner.new(str)
-        }
+        @scanner = StringScanner.new(File.read(file))
     end
 
     def shift_token