summaryrefslogtreecommitdiffstats
path: root/lib/puppet/parser/resource.rb
diff options
context:
space:
mode:
authorMarkus Roberts <Markus@reality.com>2010-07-18 13:25:43 -0700
committerMarkus Roberts <Markus@reality.com>2010-07-18 19:41:01 -0700
commitdd03ac9fa29fce36eb64a5f831be8757f2f96f5c (patch)
tree16738f07b08bd1069b3e55ce0468a51220ede02a /lib/puppet/parser/resource.rb
parent4ce33fde2c0de19d03bf5d951858dd3ea4fd52a6 (diff)
downloadpuppet-dd03ac9fa29fce36eb64a5f831be8757f2f96f5c.tar.gz
puppet-dd03ac9fa29fce36eb64a5f831be8757f2f96f5c.tar.xz
puppet-dd03ac9fa29fce36eb64a5f831be8757f2f96f5c.zip
Partial fix for #4278 -- the performance aspects
unevaluated_resources was a performance bottleneck and was doing a great deal of unneeded work, such as searching for the type of evaluated resources before ignoring them because only unevaluated resources were wanted. This patch is behaviour neutral but gives a 2-3x speedup for compiles with many defined resources.
Diffstat (limited to 'lib/puppet/parser/resource.rb')
-rw-r--r--lib/puppet/parser/resource.rb9
1 files changed, 3 insertions, 6 deletions
diff --git a/lib/puppet/parser/resource.rb b/lib/puppet/parser/resource.rb
index 3cccf4f3e..c956a1106 100644
--- a/lib/puppet/parser/resource.rb
+++ b/lib/puppet/parser/resource.rb
@@ -32,12 +32,9 @@ class Puppet::Parser::Resource < Puppet::Resource
end
# Set up some boolean test methods
- [:translated, :override, :evaluated].each do |method|
- newmeth = (method.to_s + "?").intern
- define_method(newmeth) do
- self.send(method)
- end
- end
+ def translated?; !!@translated; end
+ def override?; !!@override; end
+ def evaluated?; !!@evaluated; end
def [](param)
param = symbolize(param)