diff options
author | Brice Figureau <brice-puppet@daysofwonder.com> | 2009-10-22 20:09:27 +0200 |
---|---|---|
committer | James Turnbull <james@lovedthanlost.net> | 2009-10-25 11:10:45 +1100 |
commit | 2b57e065d2220be4f172ae429190bd116ddbdaf1 (patch) | |
tree | 3d0e23852f3385c09ac451b74bf11558961dfb3d /lib/puppet/parser/functions/generate.rb | |
parent | e8bce7a6c3d0941fb3b461d2f0487b3f249ff5f1 (diff) | |
download | puppet-2b57e065d2220be4f172ae429190bd116ddbdaf1.tar.gz puppet-2b57e065d2220be4f172ae429190bd116ddbdaf1.tar.xz puppet-2b57e065d2220be4f172ae429190bd116ddbdaf1.zip |
Fix #2691 - Collection AR request should not include params if querying with tags
f9516d introduced a change in the way the user tags are persisted
to the database: user tags are now treated as regular tags (they are
stored to the tags table).
Thus this commit changed the AR collector request to also look at the
tags tables when collecting.
Unfortunately this added a performance regression since tag request
were still importing the resources parameters tables and AR was
issuing a large request which was returning all the resource parameters
joined with the tags.
This commit fixes the AR request to join to the needed table, instead
of doing an include. Including (ie eager loading) parameter values was
not working for resource parameters anyway since at least 0.24 because
searching by parameter add a constraint to the joins and only the
searched parameter was returned instead of all parameter for a given
exported resource. So on a performance standpoint this new code should
be as fast 0.24 was.
Signed-off-by: Brice Figureau <brice-puppet@daysofwonder.com>
Diffstat (limited to 'lib/puppet/parser/functions/generate.rb')
0 files changed, 0 insertions, 0 deletions