summaryrefslogtreecommitdiffstats
path: root/lib/puppet/parser/functions.rb
diff options
context:
space:
mode:
authorJacob Helwig <jacob@puppetlabs.com>2011-06-17 11:23:21 -0700
committerJacob Helwig <jacob@puppetlabs.com>2011-06-28 15:29:02 -0700
commit014d952883246f8919d4b1935d84b301c63a34d0 (patch)
tree6e650863a92dd14d84c5b6f4b9d917fbc87db15d /lib/puppet/parser/functions.rb
parent534ccfe8d8cac382f91eea1047bca2b183e937ca (diff)
downloadpuppet-014d952883246f8919d4b1935d84b301c63a34d0.tar.gz
puppet-014d952883246f8919d4b1935d84b301c63a34d0.tar.xz
puppet-014d952883246f8919d4b1935d84b301c63a34d0.zip
Remove order dependency from functions integration spec
The test in spec/integration/parser/functions_spec.rb would fail when the spec tests were run in the order (among other orderings): spec/unit/parser/functions/tag_spec.rb spec/unit/parser/templatewrapper_spec.rb spec/integration/parser/functions_spec.rb There are tests that would cause the "template" function to be loaded into the root environment. Puppet::Parser::Functions.function("template") would then detect its presence and P::P::F.rmfunction("template") would fail since #function(...) looks in more than just the current environment to see if a function is defined, while #rmfunction(...) only looks in the current environment to see if a function can be removed. In the test ordering specified earlier, tag_spec.rb would load the "template" function, and templatewrapper_spec.rb would create a current environment that would mask the root environment for #rmfunction(...), but not for #function(...) Since #rmfunction(...) only looks in the current environment, we should be using #functions.include?("template") since that matches the check that #rmfunction(...) itself uses. Paired-with: Nick Lewis <nick@puppetlabs.com>
Diffstat (limited to 'lib/puppet/parser/functions.rb')
0 files changed, 0 insertions, 0 deletions