summaryrefslogtreecommitdiffstats
path: root/lib/puppet/parser/ast/branch.rb
diff options
context:
space:
mode:
authorMarkus Roberts <Markus@reality.com>2010-07-09 18:06:48 -0700
committerMarkus Roberts <Markus@reality.com>2010-07-09 18:06:48 -0700
commit42a539061293f8e745a9dc5b97b4415b6a275e04 (patch)
treefb268244b7ca95dd36e8136bcd3c02fd2a05632f /lib/puppet/parser/ast/branch.rb
parenta07bbe2e711ee22a40e147c046997c8813ae3cc8 (diff)
downloadpuppet-42a539061293f8e745a9dc5b97b4415b6a275e04.tar.gz
puppet-42a539061293f8e745a9dc5b97b4415b6a275e04.tar.xz
puppet-42a539061293f8e745a9dc5b97b4415b6a275e04.zip
Code smell: Use ||= for conditional initialization
Replaced 55 occurances of ([$@]?\w+) += +(.*) +(if +\1.nil\?|if +! *\1|unless +\1|unless +defined\?\(\1\))$ with \1 ||= \2 3 Examples: The code: @sync becomes: @sync The code: becomes: The code: if @yydebug becomes: if @yydebug
Diffstat (limited to 'lib/puppet/parser/ast/branch.rb')
-rw-r--r--lib/puppet/parser/ast/branch.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/puppet/parser/ast/branch.rb b/lib/puppet/parser/ast/branch.rb
index 0be6ca018..96d065e4c 100644
--- a/lib/puppet/parser/ast/branch.rb
+++ b/lib/puppet/parser/ast/branch.rb
@@ -23,7 +23,7 @@ class Puppet::Parser::AST
super(arghash)
# Create the hash, if it was not set at initialization time.
- @children = [] unless defined?(@children)
+ @children ||= []
# Verify that we only got valid AST nodes.
@children.each { |child|