summaryrefslogtreecommitdiffstats
path: root/lib/puppet/network
diff options
context:
space:
mode:
authorMarkus Roberts <Markus@reality.com>2010-01-24 18:32:25 -0800
committerMarkus Roberts <Markus@reality.com>2010-01-24 18:32:25 -0800
commit0025e13792b6a8e010ce1fd1dc20a17e7ba8af53 (patch)
tree5715206a2db5717adb7077ff786541906b8fde28 /lib/puppet/network
parentbfc9e45309abd182aac99a7dbf8960540fc05bf6 (diff)
downloadpuppet-0025e13792b6a8e010ce1fd1dc20a17e7ba8af53.tar.gz
puppet-0025e13792b6a8e010ce1fd1dc20a17e7ba8af53.tar.xz
puppet-0025e13792b6a8e010ce1fd1dc20a17e7ba8af53.zip
Partial reversion of patch for #3088 to fix #3104 (Exception misreported)
In my patch for #3088 I made a erroneous assumption about the ruby exception hierarchy and thus missed the fact that Timeout::error descends from both SignalError and Interrupt. This is a partial reversion of the patch for #3088 to let these through so that more useful error messages can be produced.
Diffstat (limited to 'lib/puppet/network')
-rw-r--r--lib/puppet/network/http/handler.rb2
-rw-r--r--lib/puppet/network/xmlrpc/client.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/puppet/network/http/handler.rb b/lib/puppet/network/http/handler.rb
index 4d9634f79..444fbf7e7 100644
--- a/lib/puppet/network/http/handler.rb
+++ b/lib/puppet/network/http/handler.rb
@@ -66,7 +66,7 @@ module Puppet::Network::HTTP::Handler
check_authorization(indirection_request)
send("do_%s" % indirection_request.method, indirection_request, request, response)
- rescue SystemExit,NoMemoryError,SignalException,Interrupt
+ rescue SystemExit,NoMemoryError
raise
rescue Exception => e
return do_exception(response, e)
diff --git a/lib/puppet/network/xmlrpc/client.rb b/lib/puppet/network/xmlrpc/client.rb
index 805d99324..9faa71c8b 100644
--- a/lib/puppet/network/xmlrpc/client.rb
+++ b/lib/puppet/network/xmlrpc/client.rb
@@ -144,7 +144,7 @@ module Puppet::Network
Puppet.debug "Calling %s.%s" % [namespace, method]
begin
call("%s.%s" % [namespace, method.to_s],*args)
- rescue SystemExit,NoMemoryError,SignalException,Interrupt
+ rescue SystemExit,NoMemoryError
raise
rescue Exception => detail
retry if self.class.error_handler(detail).execute(self, detail, namespace, method) == :retry