Feature #3347 REST-ified FileBucket

FileBucket Files have been reimplemented as an indirector terminus so that
they can be transmitted over REST.
The old Network::Client.dipper has been replaced with a compatibility later
in FileBucket::Dipper that uses the indirector to access filebucket termini.

Slightly revised patch:
* No longer allows nil contents in FileBucket outside of initialization
* Uses File.exist? instead of the deprecated File.exists?
* Tweaks JSON serialization and de-serialization to include "path"

Deferred issues:
* Feature #3371 "FileBucket should not keep files in memory".
* Feature #3372 "Replace FileBucket Dipper with more idiomatic calls"

1 files changed, 9 insertions, 1 deletions

diff --git a/lib/puppet/indirector/request.rb b/lib/puppet/indirector/request.rb
index d9e66cb5b..14608d0dc 100644
--- a/lib/puppet/indirector/request.rb
+++ b/lib/puppet/indirector/request.rb
@@ -180,6 +180,14 @@ class Puppet::Indirector::Request
         end
 
         @protocol = uri.scheme
-        @key = URI.unescape(uri.path.sub(/^\//, ''))
+
+        if uri.scheme == 'puppet'
+            @key = URI.unescape(uri.path.sub(/^\//, ''))
+            return
+        end
+
+        env, indirector, @key = URI.unescape(uri.path.sub(/^\//, '')).split('/',3)
+        @key ||= ''
+        self.environment = env unless env == ''
     end
 end