diff options
author | Jacob Helwig <jacob@puppetlabs.com> | 2011-07-22 13:21:25 -0700 |
---|---|---|
committer | Jacob Helwig <jacob@puppetlabs.com> | 2011-07-22 13:21:25 -0700 |
commit | eeb54a9e809c35a7da3c0fb68c22bbc9f4f929a8 (patch) | |
tree | 94739f0897f9359f79c14a48729e221b87709076 | |
parent | 61df3f7c39d74b82e37f48c3519293406036e1e9 (diff) | |
parent | f309e1e45c456cc1d53469863f59cbad0df37241 (diff) | |
download | puppet-eeb54a9e809c35a7da3c0fb68c22bbc9f4f929a8.tar.gz puppet-eeb54a9e809c35a7da3c0fb68c22bbc9f4f929a8.tar.xz puppet-eeb54a9e809c35a7da3c0fb68c22bbc9f4f929a8.zip |
Merge branch '2.7.x'
* 2.7.x:
Confine password disclosure acceptance test to hosts with required libraries
-rw-r--r-- | acceptance/tests/ticket_6857_password-disclosure-when-changing-a-users-password.rb | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/acceptance/tests/ticket_6857_password-disclosure-when-changing-a-users-password.rb b/acceptance/tests/ticket_6857_password-disclosure-when-changing-a-users-password.rb index f1e100c2e..d3b415691 100644 --- a/acceptance/tests/ticket_6857_password-disclosure-when-changing-a-users-password.rb +++ b/acceptance/tests/ticket_6857_password-disclosure-when-changing-a-users-password.rb @@ -1,5 +1,15 @@ test_name "#6857: redact password hashes when applying in noop mode" +hosts_to_test = agents.reject do |agent| + if agent['platform'].match /(?:ubuntu|centos|debian|rhel)/ + result = on(agent, %q{ruby -e 'require "shadow" or raise'}, :silent => true) + result.exit_code != 0 + else + false + end +end +skip_test "No suitable hosts found" if hosts_to_test.empty? + adduser_manifest = <<MANIFEST user { 'passwordtestuser': ensure => 'present', @@ -15,9 +25,9 @@ user { 'passwordtestuser': } MANIFEST -apply_manifest_on(agents, adduser_manifest ) -results = apply_manifest_on(agents, changepass_manifest ) +apply_manifest_on(hosts_to_test, adduser_manifest ) +results = apply_manifest_on(hosts_to_test, changepass_manifest ) results.each do |result| - assert_match( /current_value \[old password hash redacted\], should be \[new password hash redacted\]/ , "#{result.stdout}" ) + assert_match( /current_value \[old password hash redacted\], should be \[new password hash redacted\]/ , "#{result.host}: #{result.stdout}" ) end |