| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the previous behavior, any fact which depended on another fact in a file
not matching its name would fail to properly load the required fact, resulting
in missing, incorrect, or inconsistent values.
For instance, the operatingsystem fact depends on the lsbdistid fact found in
lsb.rb. The first time the operatingsystem fact is requested, it requires
lsb.rb, and so the required fact is loaded first. But if Facter is subsequently
cleared and the operatingsystem fact requested again, the require will not
occur, and the fact will not be automatically loaded because it doesn't match
its filename.
Now if a fact is requested and can't be found, we will attempt to load all the
facts to find it. Such an approach appears heavy-handed, but in the case where
we want a particular fact, this is the only way to make sure we've found it. In
the case where we eventually want other facts, we are conveniently eagerly
loading them.
Paired-With: Jacob Helwig <jacob@puppetlabs.com>
|
|
|
|
|
|
|
|
|
|
| |
Dir.glob returns an array, but a test was stubbing it to return a
string. In Ruby 1.8.7 if you call enumerable methods (each, collect,
etc) on a string, the string is split on \n first. This meant the poor
stubbing didn't affect 1.8.7, but 1.9.2 is more strict and won't
automatically convert when you call enumerable methods on strings.
Paired-with: Josh Cooper <josh@puppetlabs.com>
|
|\
| |
| |
| |
| |
| |
| |
| | |
'ticket/next/6728-facter_improperly_detects_openvzve_on_cloudlinux_systems' into next
* ticket/next/6728-facter_improperly_detects_openvzve_on_cloudlinux_systems:
(#6728) Facter improperly detects openvzve on CloudLinux systems
(#6883) Update Facter install.rb to be slightly more informative.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Make the openvz check for more than just the vz directory to be sure it's
OpenVZ.
Update the OpenVZ fact to be slightly more resilient in it's checking of
OpenVZ, so it doesn't clash with CloudLinux's LVE container system.
|
| |
| |
| |
| |
| | |
The sysctl uptime fixture was little endian, which fails on sparc
hardware. Added a big endian fixture and endian detection.
|
| |
| |
| |
| |
| | |
renames Facter::Util::Resolution#length to weight as a more generic
mechanism for allowing resolutions to state their importance
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | | |
* adrien/tickets/next/2714:
(#2714) Fixed faulty test
(#2714) Added timeout to prtdiag resulution
|
| | |
| | |
| | |
| | |
| | |
| | | |
- Looks like some copy/paste added some linux tests that relied on
prtdiag, which isn't possible. Corrected them to check against
solaris.
|
| |/
| |
| |
| | |
prtdiag for Solaris and corresponding tests. Darwin case is not handled yet.
|
| |
| |
| |
| | |
- Refactored code to make testing simpler
|
|/
|
|
| |
prtdiag for Solaris and corresponding tests. Darwin case is not handled yet.
|
| |
|
|\
| |
| |
| |
| |
| | |
* tickets/next/6716-osx-ipv6-macaddress:
Clean up indentation, and alignment in macaddress_spec.rb
(#6716) fix facter issues on OSX with ipv6 in macaddress.rb.
|
| |
| |
| |
| |
| |
| |
| | |
This changes the spec file from 4-space indentations to 2-space
indentations to match the style guide[1].
[1] http://projects.puppetlabs.com/projects/puppet/wiki/Development_Lifecycle#Style
|
| |
| |
| |
| |
| |
| | |
Due to "netstat -rn" returning multiple protocols (IPv4 and IPv6) the
"default_interface" can get more than one entry in to it, causing the
macaddress resolving to break. This limits it to just one interface.
|
| |
| |
| |
| |
| | |
Added facts arp (like the ipaddress etc) facts
Added facts arp_interfacename
|
| |
| |
| |
| |
| |
| |
| | |
Added support for VMWareESX and ESXi to operatingsystem and
operatingsystemrelease facts
Added appropriate tests
|
|\ \ |
|
| |/ |
|
|\ \ |
|
| |/ |
|
| |
| |
| |
| |
| | |
- Added swapfree and swapsize facts
- Tests will now run correctly for osx swap tests
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Patch modified from Hector Rivas
|
|\ \ \ |
|
| | |/
| |/|
| | |
| | | |
Thanks to James Goddard for the patch
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
1. Added new facts for all values returned by the sestatus command
2. Updated legacy selinux_mode fact with former value
3. Added note and ticket #6677 to remove legacy fact at Facter 2.0.0
4. Added tests for new facts and legacy fact
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
1. Fixed IP return to not filter lo/localhost and return it
as a proper interface
2. Fixed HP-UX netstat return to remove extraneous first line
of naming.
3. Updated tests to reflect changes
|
|/ /
| |
| |
| |
| |
| | |
1. Added tested
2. Refactored to use F:U:R.exec
3. Chomp trailing newline
|
|/
|
|
|
|
|
|
|
|
| |
It's not clear to me how these are now needed and apparently
weren't when we first checked this in. These stubs will let the
specs continue on so we can check the load order, which was the
original intent of (#5510) which caused the introduction of these
specs.
Signed-off-by: Rick Bradley <rick@rickbradley.com>
|
| |
|
|\ |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
This stubs out the platform side of the code, and uses fixtures emitting the
right output from the interface configuration tools.
Paired-With: Matt Robinson <matt@puppetlabs.com>
Paired-With: Max Martin <max@puppetlabs.com>
|
|/
|
|
|
|
|
|
| |
This adds a suite-wide "Facter.clear" call before :each test case to ensure
that we can't accidentally cache data when we are invoked using top level
Facter interfaces to get at data.
Paired-with: Jacob Helwig <jacob@puppetlabs.com>
|
|
|
|
|
|
|
|
|
| |
Merged manually to the current state of the art. Minimal conflicts resolved
by adding both Darwin and GNU/KFreeBSD to the confine lines.
Author: Marc Fournier <marc.fournier@camptocamp.com>
Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
Signed-off-by: Rick Bradley <rick@rickbradley.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ruby's Dir.entries will return files in different orders depending on
the OS and/or filesystem. As a result Facter::Util::Loader will load
ruby custom fact definitions in different orders on different platforms.
Specs to expose the bugs, and code to ensure that custom fact files are
loaded in alphabetical order.
Addresses redmine issue #5510
http://projects.puppetlabs.com/issues/5510
Signed-off-by: Rick Bradley <rick@rickbradley.com>
Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
|
|
|
|
|
|
| |
Rename all the spec tests to follow the rspec convention of *_spec.rb rather
than unadorned *.rb; this also makes it easier to work with them consistently
without using the Rakefile support that customizes that.
|
|
|
|
|
|
| |
Because we pull in spec_helper in individual tests, we need to use a
consistent path or Ruby will evaluate it multiple times. Make the path
consistent by expanding it before require.
|
|
|
|
| |
We have moved to rspec2 for puppet, and facter should follow suit.
|
|
|
|
|
|
|
|
|
| |
'who -b' doesn't report the year of the last system boot on (at least)
Solaris 10, and OpenSolaris 2009.06. Try using 'kstat -p
unix:::boot_time', which reports as seconds since the epoch on these
systems before falling back to 'who -b'.
Reviewed-by: Paul Berry <paul@puppetlabs.com>
|
|
|
|
| |
Reviewed-by: Paul Berry <paul@puppetlabs.com>
|
|
|
|
|
|
|
|
| |
While looking at the patch for adding parallels to the virtual types
David Schmitt noticed that it might be easier just to list the types
that are NOT virtual since there's fewer of them.
Paired-with: Nick Lewis
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds support for Parallels VM guest detection with existing operating
systems. Detects Parallels based on hardware vendor name and pci id. The
Parallels vendor id does not seem to be listed in most pci.ids.
Adds resolution for "virtual" fact in the Darwin kernel. This uses the
existing Facter::Util::Macosx module to resolve system profiler data.
Both vendor name and vendor id values are checked. Resolution appears to
vary based on VM Host product.
Signed-off-by: donavanm <donavan@desinc.net>
|
|
|
|
|
|
|
| |
Just tests the regex, won't actually catch problems if prtdiag doesn't
return output like our test.
Paired-with: Nick Lewis
|
| |
|
|
|
|
|
| |
Parses `/usr/sbin/xm list` and returns a comma-separated list of
domains. Based on a patch submitted by Jonas Genannt.
|
|\
| |
| |
| |
| |
| | |
Manually resolved conflicts:
lib/facter/virtual.rb
spec/unit/virtual.rb
|