Added a Process.waitall thread when there's a timeout, to avoid zombies.

Without this call, every time there's a timeout, we'll get a zombie.

1 files changed, 11 insertions, 0 deletions

diff --git a/spec/unit/util/resolution.rb b/spec/unit/util/resolution.rb
index 5ce3d63..643be33 100755
--- a/spec/unit/util/resolution.rb
+++ b/spec/unit/util/resolution.rb
@@ -112,6 +112,17 @@ describe Facter::Util::Resolution do
 
                 @resolve.value.should be_nil
             end
+
+            it "should waitall to avoid zombies if the timeout is exceeded" do
+                @resolve.stubs(:warn)
+                @resolve.timeout = 0.1
+                @resolve.setcode { sleep 2; raise "This is a test" }
+
+                Thread.expects(:new).yields
+                Process.expects(:waitall)
+
+                @resolve.value
+            end
         end
     end