summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRob Crittenden <rcritten@redhat.com>2015-09-24 11:59:49 -0400
committerRob Crittenden <rcritten@redhat.com>2015-10-02 16:51:56 -0400
commit2341ceb7936b9e46d1fe00722ccbd4af44091907 (patch)
treea671c39aaf50137c3cd31d12b3c8f79c15c14bcb
parent9a81757673c89db67d7e4a6772b86fc713aebef6 (diff)
downloadmod_nss-2341ceb7936b9e46d1fe00722ccbd4af44091907.tar.gz
mod_nss-2341ceb7936b9e46d1fe00722ccbd4af44091907.tar.xz
mod_nss-2341ceb7936b9e46d1fe00722ccbd4af44091907.zip
Fix cipher memory leak and use PORT_Free instead of PR_Free
When retrieving the negotiated cipher the string was being leaked and the wrong free was being used for subject and issuer.
-rw-r--r--nss_engine_vars.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/nss_engine_vars.c b/nss_engine_vars.c
index 0a4dd14..517a691 100644
--- a/nss_engine_vars.c
+++ b/nss_engine_vars.c
@@ -691,8 +691,9 @@ static char *nss_var_lookup_nss_cipher(apr_pool_t *p, conn_rec *c, char *var)
if (result != NULL && resdup)
result = apr_pstrdup(p, result);
- PR_Free(issuer);
- PR_Free(subject);
+ PORT_Free(issuer);
+ PORT_Free(subject);
+ PORT_Free(cipher);
return result;
}