251: Fixed Command.validate() so it raises RequirementError; updated and re-enabled unit tests for Command.validate()

1 files changed, 6 insertions, 3 deletions

diff --git a/ipalib/public.py b/ipalib/public.py
index 91f357ca..c64e29d5 100644
--- a/ipalib/public.py
+++ b/ipalib/public.py
@@ -222,9 +222,12 @@ class Command(plugable.Plugin):
 
     def validate(self, **kw):
         self.print_call('validate', kw, 1)
-        for (key, value) in kw.iteritems():
-            if key in self.Option:
-                self.Option[key].validate(value)
+        for option in self.Option():
+            value = kw.get(option.name, None)
+            if value is not None:
+                option.validate(value)
+            elif option.required:
+                raise errors.RequirementError(option.name)
 
     def execute(self, **kw):
         self.print_call('execute', kw, 1)