diff options
| author | Petr Vobornik <pvoborni@redhat.com> | 2011-12-05 13:39:30 +0100 |
|---|---|---|
| committer | Endi S. Dewata <edewata@redhat.com> | 2011-12-05 16:02:11 +0000 |
| commit | 1ffbec9942ad90e00e28b05296d3233f52ce2dad (patch) | |
| tree | db2226435f5a925a8073f482e626565c3d2e4375 /install/ui/field.js | |
| parent | c5ca34f41d2aede667c19d2213a5d7e79a5e301c (diff) | |
| download | freeipa.git-1ffbec9942ad90e00e28b05296d3233f52ce2dad.tar.gz freeipa.git-1ffbec9942ad90e00e28b05296d3233f52ce2dad.tar.xz freeipa.git-1ffbec9942ad90e00e28b05296d3233f52ce2dad.zip | |
Removed usage of bitwise assignment operators in logical operations
JavaScript &= and |= are bitwise operators. They are shortened version of:
foo = foo & bar
foo = foo | bar
In some places they were used as shortened version of logical operation and assignment.
foo = foo && bar
It lead to type conversion to Number which is wrong (0 !== false).
This patch replaces such occurances with full version of logical operation and asignment.
https://fedorahosted.org/freeipa/ticket/2040
Diffstat (limited to 'install/ui/field.js')
| -rw-r--r-- | install/ui/field.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/install/ui/field.js b/install/ui/field.js index 2cba8786..381f2360 100644 --- a/install/ui/field.js +++ b/install/ui/field.js @@ -301,8 +301,8 @@ IPA.field = function(spec) { if (!value) empty = true; if (value instanceof Array) { - empty |= (value.length === 0) || - (value.length === 1) && (value[0] === ''); + empty = empty || value.length === 0 || + (value.length === 1) && (value[0] === ''); } if (value === '') empty = true; @@ -480,7 +480,7 @@ IPA.multivalued_field = function(spec) { that.test_dirty = function() { var dirty = that.field_test_dirty(); - dirty |= that.widget.test_dirty(); //also checks order + dirty = dirty || that.widget.test_dirty(); //also checks order return dirty; }; |