Navigation updates

The entity.default_facet has been removed, instead the first facet
registered to the entity will be considered as the default facet.
So, the 'setup' parameter has been removed from tab definitions
because it's no longer necessary. The ipa_details_only_setup() has
been removed as well.

An 'entity' parameter has been added to tab definitions to specify
which entity corresponds to a tab item. The tab label has been
changed to use entity label if available.

Some hard-coded labels have been removed. The unit tests have been
updated.

1 files changed, 9 insertions, 10 deletions

diff --git a/install/static/navigation.js b/install/static/navigation.js
index aa03becc..8089e2ea 100644
--- a/install/static/navigation.js
+++ b/install/static/navigation.js
@@ -76,8 +76,9 @@ function nav_generate_tabs(nls, container, tabclass, depth)
         var tab = nls[i];
 
         var label = tab.name;
-        if ((IPA.metadata[tab.name]) && (IPA.metadata[tab.name].label)){
-            label = IPA.metadata[tab.name].label;
+        if (tab.entity) {
+            var entity = IPA.get_entity(tab.entity);
+            label = entity.label;
         }
 
         var li = nav_create_tab_li(tab.name, label);
@@ -86,14 +87,12 @@ function nav_generate_tabs(nls, container, tabclass, depth)
         var div = nav_create_tab_div(tab.name);
         container.append(div);
 
-        if (tab.children && depth === 1) {
-            nav_generate_tabs(tab.children, div, tabclass, depth +1 );
-        } else {
+        if (tab.entity) {
             div.addClass('entity-container');
+        }
 
-            var entity = ipa_get_entity(tab.name);
-            entity.label = tab.label;
-            entity.setup = tab.setup;
+        if (tab.children && depth === 1) {
+            nav_generate_tabs(tab.children, div, tabclass, depth +1 );
         }
     }
 }
@@ -133,8 +132,8 @@ function _nav_update_tabs(nls, container,depth)
     if (tab.children   && depth === 1 ) {
         _nav_update_tabs(tab.children, container2,depth+1);
 
-    } else if (tab.setup) {
-        var entity_name = tab.name;
+    } else if (tab.entity) {
+        var entity_name = tab.entity;
 
         var nested_entity = nav_get_state(entity_name+'-entity');