summaryrefslogtreecommitdiffstats
path: root/daemons/ipa-slapi-plugins/ipa-winsync
diff options
context:
space:
mode:
authorMartin Kosek <mkosek@redhat.com>2011-01-14 10:24:04 +0100
committerSimo Sorce <ssorce@redhat.com>2011-01-14 14:20:57 -0500
commitc94d20cfd8cc1bd8cd8152b19d6807b654286197 (patch)
tree963fb678ee96ef9403e1fa54d0d1d94bc4976193 /daemons/ipa-slapi-plugins/ipa-winsync
parenta6a91e5dbc96498ef33505e4bf96466590f0da42 (diff)
downloadfreeipa.git-c94d20cfd8cc1bd8cd8152b19d6807b654286197.tar.gz
freeipa.git-c94d20cfd8cc1bd8cd8152b19d6807b654286197.tar.xz
freeipa.git-c94d20cfd8cc1bd8cd8152b19d6807b654286197.zip
Unchecked return values in SLAPI plugins
Return values weren't checked in several cases which could have lead to unhandled errors. https://fedorahosted.org/freeipa/ticket/722
Diffstat (limited to 'daemons/ipa-slapi-plugins/ipa-winsync')
-rw-r--r--daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c b/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c
index 1293c4c7..a61cabb1 100644
--- a/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c
+++ b/daemons/ipa-slapi-plugins/ipa-winsync/ipa-winsync-config.c
@@ -702,8 +702,8 @@ internal_find_entry_get_attr_val(const Slapi_DN *basedn, int scope,
if (entries && entries[0]) { /* found one */
if (svs) {
Slapi_Attr *attr = NULL;
- slapi_entry_attr_find(entries[0], attrname, &attr);
- if (attr) {
+ if (!slapi_entry_attr_find(entries[0], attrname, &attr) &&
+ (NULL != attr)) {
/* slapi_attr_get_valueset allocates svs - must be freed later */
slapi_attr_get_valueset(attr, svs);
}