summaryrefslogtreecommitdiffstats
path: root/ctdb/lib/tdb/common/lock.c
Commit message (Collapse)AuthorAgeFilesLines
* ctdb-build: Remove duplicate tdb libraryAmitay Isaacs2014-06-201-875/+0
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Michael Adam <obnox@samba.org>
* tdb: Sync to tdb 1.2.11 from upstreamAmitay Isaacs2013-05-291-1/+1
| | | | (This used to be ctdb commit bb3a32ec055432afc7225c9fd7504fb187694bda)
* lib/tdb: Sync tdb from samba git treeAmitay Isaacs2012-04-131-32/+24
| | | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> (This used to be ctdb commit 0f40ea2386892ae10b30beeded0e00edf4c019c3)
* tdb: expose transaction lock infrastructure for ctdbRusty Russell2011-01-181-0/+20
| | | | | | | | | tdb_traverse_read() grabs the transaction lock. This can cause ctdbd (which uses it) to block when it should not; expose mark and normal variants of this lock, so ctdbd's child (the recovery daemon) can acquire it and the ctdbd parent can mark it was held. (This used to be ctdb commit d09fa845bd848d04507853809acf42e0471b44bf)
* tdb: workaround starvation problem in locking entire database.Rusty Russell2010-08-161-17/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (Imported from SAMBA 11ab43084b10cf53b530cdc3a6036c898b79ca38) We saw tdb_lockall() take 71 seconds under heavy load; this is because Linux (at least) doesn't prevent new small locks being obtained while we're waiting for a big log. The workaround is to do divide and conquer using non-blocking chainlocks: if we get down to a single chain we block. Using a simple test program where children did "hold lock for 100ms, sleep for 1 second" the time to do tdb_lockall() dropped signifiantly. There are ln(hashsize) locks taken in the contended case, but that's slow anyway. More analysis is given in my blog at http://rusty.ozlabs.org/?p=120 This may also help transactions, though in that case it's the initial read lock which uses this gradual locking routine; the update-to-write-lock code is separate and still tries to update in one go. Even though ABI doesn't change, minor version bumped so behavior change can be easily detected. CQ:S1018154 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (This used to be ctdb commit 9ec0009443a0ac4187ce5212a5143689daa58a02)
* tdb: Add a non-blocking version of tdb_transaction_startVolker Lendecke2010-04-221-2/+3
| | | | | | (Imported from commit 261c3b4f1beed820647061bacbee3acccbcbb089) (This used to be ctdb commit 87ced00d6d98be4a34719af58694e7c940b4dd68)
* Fix some nonempty blank linesVolker Lendecke2010-04-221-2/+2
| | | | | | (Imported from commit ea8e0d5d54b020c530e392c4edaeed43e20af303) (This used to be ctdb commit 7161cb1607bb105cd6f4f32df50f519314e77b3f)
* tdb: handle processes dying during transaction commit.Rusty Russell2010-04-221-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | tdb transactions were designed to be robust against the machine powering off, but interestingly were never designed to handle the case where an administrator kill -9's a process during commit. Because recovery is only done on tdb_open, processes with the tdb already mapped will simply use it despite it being corrupt and needing recovery. The solution to this is to check for recovery every time we grab a data lock: we could have gained the lock because a process just died. This has no measurable cost: here is the time for tdbtorture -s 0 -n 1 -l 10000: Before: 2.75 2.50 2.81 3.19 2.91 2.53 2.72 2.50 2.78 2.77 = Avg 2.75 After: 2.81 2.57 3.42 2.49 3.02 2.49 2.84 2.48 2.80 2.43 = Avg 2.74 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit ec96ea690edbe3398d690b4a953d487ca1773f1c) (This used to be ctdb commit 4215c7025d2b29439c5acd19ce4e0fc4e67370b3)
* patch tdb-refactor-tdb_lock-and-tdb_lock_nonblock.patchRusty Russell2010-04-221-16/+13
| | | | | | (Imported from commit 1bf482b9ef9ec73dd7ee4387d7087aa3955503dd) (This used to be ctdb commit 52b0f19636565ef633e63d2726a1cc8c41dccedb)
* tdb: remove lock opsRusty Russell2010-04-221-15/+22
| | | | | | | | | | | | | | | Now the transaction code uses the standard allrecord lock, that stops us from trying to grab any per-record locks anyway. We don't need to have special noop lock ops for transactions. This is a nice simplification: if you see brlock, you know it's really going to grab a lock. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit 9f295eecffd92e55584fc36539cd85cd32c832de) (This used to be ctdb commit 6d7093cf51d0256245cc6bab24c9550ed3f1d8a5)
* tdb: rename tdb_release_extra_locks() to tdb_release_transaction_locks()Rusty Russell2010-04-221-10/+7
| | | | | | | | | | | | tdb_release_extra_locks() is too general: it carefully skips over the transaction lock, even though the only caller then drops it. Change this, and rename it to show it's clearly transaction-specific. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit a84222bbaf9ed2c7b9c61b8157b2e3c85f17fa32) (This used to be ctdb commit 803035716338170896fee15f15b17c32e7ee777e)
* tdb: tdb_allrecord_lock/tdb_allrecord_unlock/tdb_allrecord_upgradeRusty Russell2010-04-221-20/+52
| | | | | | | | | | | | | | | | | | | | | Centralize locking of all chains of the tdb; rename _tdb_lockall to tdb_allrecord_lock and _tdb_unlockall to tdb_allrecord_unlock, and tdb_brlock_upgrade to tdb_allrecord_upgrade. Then we use this in the transaction code. Unfortunately, if the transaction code records that it has grabbed the allrecord lock read-only, write locks will fail, so we treat this upgradable lock as a write lock, and mark it as upgradable using the otherwise-unused offset field. One subtlety: now the transaction code is using the allrecord_lock, the tdb_release_extra_locks() function drops it for us, so we no longer need to do it manually in _tdb_transaction_cancel. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit fca1621965c547e2d076eca2a2599e9629f91266) (This used to be ctdb commit d7fdb38ac05b5f2af9eb485e98673280835273dd)
* tdb: suppress record write locks when allrecord lock is taken.Rusty Russell2010-04-221-0/+9
| | | | | | | | | | | | | | | | | | | Records themselves get (read) locked by the traversal code against delete. Interestingly, this locking isn't done when the allrecord lock has been taken, though the allrecord lock until recently didn't cover the actual records (it now goes to end of file). The write record lock, grabbed by the delete code, is not suppressed by the allrecord lock. This is now bad: it causes us to punch a hole in the allrecord lock when we release the write record lock. Make this consistent: *no* record locks of any kind when the allrecord lock is taken. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit caaf5c6baa1a4f340c1f38edd99b3a8b56621b8b) (This used to be ctdb commit 7a99cdf5d0a91764a750c1a264e90e5b66f910a1)
* tdb: cleanup: always grab allrecord lock to infinity.Rusty Russell2010-04-221-7/+3
| | | | | | | | | | | | | | We were previously inconsistent with our "global" lock: the transaction code grabbed it from FREELIST_TOP to end of file, and the rest of the code grabbed it from FREELIST_TOP to end of the hash chains. Change it to always grab to end of file for simplicity and so we can merge the two. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit 9341f230f8968b4b18e451d15dda5ccbe7787768) (This used to be ctdb commit 46f2c33357c999c31a8064c159c6162269c28d9d)
* tdb: remove num_locksRusty Russell2010-04-221-10/+2
| | | | | | | | | | | | | | This was redundant before this patch series: it mirrored num_lockrecs exactly. It still does. Also, skip useless branch when locks == 1: unconditional assignment is cheaper anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit 1ab8776247f89b143b6e58f4b038ab4bcea20d3a) (This used to be ctdb commit 587ac01ce836286aab54bfcb7a693a0170c7ebd3)
* tdb: use tdb_nest_lock() for active lock.Rusty Russell2010-04-221-0/+8
| | | | | | | | | | | | | Use our newly-generic nested lock tracking for the active lock. Note that the tdb_have_extra_locks() and tdb_release_extra_locks() functions have to skip over this lock now it is tracked. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit 4738d474c412cc59d26fcea64007e99094e8b675) (This used to be ctdb commit 0a44584963232b0b1c62e30c9bede0439e68ef7d)
* tdb: use tdb_nest_lock() for open lock.Rusty Russell2010-04-221-1/+2
| | | | | | | | | | | | | | | This never nests, so it's overkill, but it centralizes the locking into lock.c and removes the ugly flag in the transaction code to track whether we have the lock or not. Note that we have a temporary hack so this places a real lock, despite the fact that we are in a transaction. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit 9136818df30c7179e1cffa18201cdfc990ebd7b7) (This used to be ctdb commit 6812d81907793299e874f121174d885f6500f374)
* tdb: use tdb_nest_lock() for transaction lock.Rusty Russell2010-04-221-31/+23
| | | | | | | | | | | | | | Rather than a boutique lock and a separate nest count, use our newly-generic nested lock tracking for the transaction lock. Note that the tdb_have_extra_locks() and tdb_release_extra_locks() functions have to skip over this lock now it is tracked. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit e8fa70a321d489b454b07bd65e9b0d95084168de) (This used to be ctdb commit 4ca1b96a70048b2eaa0d12fb5f0fdb54ec396aa3)
* tdb: cleanup: find_nestlock() helper.Rusty Russell2010-04-221-28/+23
| | | | | | | | | | | Factor out two loops which find locks; we are going to introduce a couple more so a helper makes sense. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit ce41411c84760684ce539b6a302a0623a6a78a72) (This used to be ctdb commit cfb154dd0f189f37b937e90144c2eb9e66a26420)
* tdb: cleanup: tdb_release_extra_locks() helperRusty Russell2010-04-221-0/+20
| | | | | | | | | | | Move locking intelligence back into lock.c, rather than open-coding the lock release in transaction.c. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit db270734d8b4208e00ce9de5af1af7ee11823f6d) (This used to be ctdb commit d2dd720b51c4032e5d77d30212da8117d3f119df)
* tdb: cleanup: tdb_have_extra_locks() helperRusty Russell2010-04-221-2/+13
| | | | | | | | | | | | | In many places we check whether locks are held: add a helper to do this. The _tdb_lockall() case has already checked for the allrecord lock, so the extra work done by tdb_have_extra_locks() is merely redundant. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit fba42f1fb4f81b8913cce5a23ca5350ba45f40e1) (This used to be ctdb commit dda3587dfee598f387c2e696f3645486fac65052)
* tdb: don't suppress the transaction lock because of the allrecord lock.Rusty Russell2010-04-221-6/+0
| | | | | | | | | | | | | | | | | | | | | | tdb_transaction_lock() and tdb_transaction_unlock() do nothing if we hold the allrecord lock. However, the two locks don't overlap, so this is wrong. This simplification makes the transaction lock a straight-forward nested lock. There are two callers for these functions: 1) The transaction code, which already makes sure the allrecord_lock isn't held. 2) The traverse code, which wants to stop transactions whether it has the allrecord lock or not. There have been deadlocks here before, however this should not bring them back (I hope!) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit b754f61d235bdc3e410b60014d6be4072645e16f) (This used to be ctdb commit 495f3554259b9dbf9ee673c4fe420d98e50e4901)
* tdb: cleanup: tdb_nest_lock/tdb_nest_unlockRusty Russell2010-04-221-43/+61
| | | | | | | | | | | | | | | | | | | | | | Because fcntl locks don't nest, we track them in the tdb->lockrecs array and only place/release them when the count goes to 1/0. We only do this for record locks, so we simply place the list number (or -1 for the free list) in the structure. To generalize this: 1) Put the offset rather than list number in struct tdb_lock_type. 2) Rename _tdb_lock() to tdb_nest_lock, make it non-static and move the allrecord check out to the callers (except the mark case which doesn't care). 3) Rename _tdb_unlock() to tdb_nest_unlock(), make it non-static and move the allrecord out to the callers (except mark again). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit 5d9de604d92d227899e9b861c6beafb2e4fa61e0) (This used to be ctdb commit 28576ddbd9bf91049db8a4f9e9e7856ac5b8f48a)
* tdb: cleanup: rename global_lock to allrecord_lock.Rusty Russell2010-04-221-21/+21
| | | | | | | | | | | | | The word global is overloaded in tdb. The global_lock inside struct tdb_context is used to indicate we hold a lock across all the chains. Rename it to allrecord_lock. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit e9114a758538d460d4f9deae5ce631bf44b1eff8) (This used to be ctdb commit a912657fb50a78b9b328c4564281fb9f7f1b3766)
* tdb: cleanup: split brlock and brunlock methods.Rusty Russell2010-04-221-73/+162
| | | | | | | | | | | | | | | | | | | | | This is taken from the CCAN code base: rather than using tdb_brlock for locking and unlocking, we split it into brlock and brunlock functions. For extra debugging information, brunlock says what kind of lock it is unlocking (even though fnctl locks don't need this). This requires an extra argument to tdb_transaction_unlock() so we know whether the lock was upgraded to a write lock or not. We also use a "flags" argument tdb_brlock: 1) TDB_LOCK_NOWAIT replaces lck_type = F_SETLK (vs F_SETLKW). 2) TDB_LOCK_MARK_ONLY replaces setting TDB_MARK_LOCK bit in ltype. 3) TDB_LOCK_PROBE replaces the "probe" argument. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (Imported from commit 452b4a5a6efeecfb5c83475f1375ddc25bcddfbe) (This used to be ctdb commit 7b5fdc9c588237c83a1e70e5437e2e5510055b92)
* lib/tdb: wean off TDB_ERRCODE.Rusty Russell2009-12-161-11/+19
| | | | | | | | | | | | | | | It was a regrettable hack which I used to reduce line count in tdb; in fact it caused confusion as can be seen in this patch. In particular, ecode now needs to be set before TDB_LOG anyway, and having it exposed in the header is useless (the struct tdb_context isn't defined, so it's doubly useless). Also, we should never set errno, as io.c was doing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (cherry picked from samba commit b77f41d58b05101e02d8ac0e54cb0e30807d89c2) Signed-off-by: Stefan Metzmacher <metze@samba.org> (This used to be ctdb commit a6620f6e74aadc708395b21b42303d1082192fcc)
* lib/tdb: TDB_TRACE support (for developers)Rusty Russell2009-12-161-6/+28
| | | | | | | | | | | | | | | | | | When TDB_TRACE is defined (in tdb_private.h), verbose tracing of tdb operations is enabled. This can be replayed using "replay_trace" from http://ccan.ozlabs.org/info/tdb. The majority of this patch comes from moving internal functions to _<funcname> to avoid double-tracing. There should be no additional overhead for the normal (!TDB_TRACE) case. Note that the verbose traces compress really well with rzip. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (cherry picked from samba commit 703004340c3e0f43f741bd368d2525cfd187d590) Signed-off-by: Stefan Metzmacher <metze@samba.org> (This used to be ctdb commit b01b756cb577f32a1ec4597efb00017241e01685)
* Port from SAMBA tdb: commit 54a51839ea65aa788b18fce8de0ae4f9ba63e4e7 Author: ↵Rusty Russell2009-08-041-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rusty Russell <rusty@rustcorp.com.au> Date: Sat Jul 18 15:28:58 2009 +0930 Make tdb transaction lock recursive (samba version) This patch replaces 6ed27edbcd3ba1893636a8072c8d7a621437daf7 and 1a416ff13ca7786f2e8d24c66addf00883e9cb12, which fixed the bug where traversals inside transactions would release the transaction lock early. This solution is more general, and solves the more minor symptom that nested traversals would also release the transaction lock early. (It was also suggestd in Volker's comment in 6ed27ed). This patch also applies to ctdb, if the traverse.c part is removed (ctdb's tdb code never received the previous two fixes). Tested using the testsuite from ccan (adapted to the samba code). Thanks to Michael Adam for feedback. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Michael Adam <obnox@samba.org> commit 760104188d0d2ed96ec4a70138e6d0bf86d797ed Author: Rusty Russell <rusty@rustcorp.com.au> Date: Tue Jul 21 16:23:35 2009 +0930 tdb: fix locking error 54a51839ea65aa788b18fce8de0ae4f9ba63e4e7 "Make tdb transaction lock recursive (samba version)" was broken: I "cleaned it up" and prevented it from ever unlocking. To see the problem: $ bin/tdbtorture -s 1248142523 tdb_brlock failed (fd=3) at offset 8 rw_type=1 lck_type=14 len=1 tdb_transaction_lock: failed to get transaction lock tdb_transaction_start failed: Resource deadlock avoided My testcase relied on the *count* being correct, which it was. Fixing that now. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Michael Adam <obnox@samba.org> (This used to be ctdb commit ce19658ba13272238058e9b9bc03e62f48b737c0)
* merge from Samba4Andrew Tridgell2008-01-051-0/+12
| | | | (This used to be ctdb commit 9aed7a1d065272c2e5b54872228a73f37664b526)
* convert tdb from u32 to uint32_t to match the current Samba treesAndrew Tridgell2008-01-051-1/+1
| | | | (This used to be ctdb commit 0dc754b7e8b0985a252885ed043949dfb7ea1ae1)
* update lib/tdb from samba4Andrew Tridgell2007-07-101-2/+1
| | | | (This used to be ctdb commit 96a39ccee38bcfd64d614fe4670766e59ef246b6)
* update lib/replace from samba4Andrew Tridgell2007-07-101-1/+1
| | | | (This used to be ctdb commit f0555484105668c01c21f56322992e752e831109)
* - merged ctdb_store test from ronnieAndrew Tridgell2007-06-171-0/+7
| | | | | | | - added DatabaseHashSize tunable - added logging of events inside recovery (for timing) (This used to be ctdb commit 3593cdb928b91e217faf1b3c537fa28dc82cdace)
* global lock should imply the transaction lockAndrew Tridgell2007-05-221-0/+35
| | | | (This used to be ctdb commit 765a7e27344476ea8835565839b69872ea6ab6f0)
* added _mark calls for tdb_lockallAndrew Tridgell2007-05-121-2/+24
| | | | (This used to be ctdb commit e59134fd2af67c746b907c23fdcde2eccbbe17cf)
* added nonblocking varients of the two lockall functions to tdbAndrew Tridgell2007-05-101-5/+21
| | | | (This used to be ctdb commit 2e99fa41ce01fa282bc0f3244ca42a78173743ed)
* added tdb_chainlock_mark() call, which can be used to mark a chain locked ↵Andrew Tridgell2007-05-051-3/+28
| | | | | | without actually locking it. This will be used to guarantee forward progress in the ctdb non-blocking lockwait code (This used to be ctdb commit 2af98c3418496b39106c7282f550049ec8239657)
* added a tdb_chainlock_nonblock() call to tdbAndrew Tridgell2007-04-161-4/+29
| | | | (This used to be ctdb commit 6587bdca71d97709c9271a73aea0be5a2a35f399)
* merge local copy of tdb from samba4 tdbAndrew Tridgell2007-04-161-18/+88
| | | | (This used to be ctdb commit d4619ce98ce44acaebeb6ae9c516a7917bf4e27f)
* added rest of tdb (missed in earlier commit)Andrew Tridgell2007-02-201-0/+342
(This used to be ctdb commit 4c1434cc4613fc94958de0aa882bf7ca41ec8458)
generated by cgit (git 2.34.1) at 2025-09-26 13:13:30 +0000