summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* s4:drsuapi: check the source_dsa_invocation_id (bug #9508)Stefan Metzmacher2013-01-011-0/+15
| | | | | | | | The given highwatermark is only valid relative to the specified source_dsa_invocation_id. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:drsuapi: make sure we never return the same highwatermark twice in a ↵Stefan Metzmacher2013-01-011-0/+36
| | | | | | | | | | | replication cycle (bug #9508) If the highwatermark given by the client is not the one we expect, we need to start a new replication cycle. Otherwise the destination dsa skips objects and linked attribute values. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:drsuapi: add drsuapi_DsReplicaHighWaterMark_cmp()Stefan Metzmacher2013-01-011-0/+20
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:drsuapi: always use the current uptodateness_vectorStefan Metzmacher2013-01-011-11/+9
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:drsuapi: avoid a ldb_dn_copy() and use talloc_move() insteadStefan Metzmacher2013-01-011-3/+3
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:drsuapi: remove unused 'highest_usn' from drsuapi_getncchanges_stateStefan Metzmacher2013-01-011-4/+0
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:drsuapi: move struct drsuapi_getncchanges_state to the top of getncchanges.cStefan Metzmacher2013-01-011-17/+17
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:dsdb/drepl: update the source_dsa_obj/invocation_id in repsFromStefan Metzmacher2013-01-011-0/+4
| | | | | | | The highwatermark is relative to the source_dsa_invocation_id. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:dsdb/common: use 01.01.1970 as last_sync_success for our entry in the ↵Stefan Metzmacher2013-01-011-3/+4
| | | | | | | | | uptodatevector This matches a Windows 2008R2 and 2012 server. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:dsdb/common: use LDB_SEQ_HIGHEST_SEQ for our entry in the uptodatevectorStefan Metzmacher2013-01-011-2/+2
| | | | | | | | | We should use the global highestCommittedUSN, not the per partition value. This matches a Windows 2008R2 and 2012 server. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:dsdb/repl_meta_data: don't merge highwatermark and uptodatevector (bug #9508)Stefan Metzmacher2013-01-011-38/+1
| | | | | | | | | We should not do any magic regarding the highwatermark we got from the source dsa. We need to treat it as opaque and not try to be smart and merge it into the uptodatevector. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:dsdb/repl_meta_data: also update the last_sync_success in replUpToDateVectorStefan Metzmacher2013-01-011-5/+1
| | | | | | | This matches Windows 2008R2 and Windows 2012. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:dsdb/repl_meta_data: store the last results and timestamps in the repsFromStefan Metzmacher2013-01-011-0/+3
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:dsdb/repl_meta_data: always treat the highwatermark as opaque (bug #9508)Stefan Metzmacher2013-01-011-1/+0
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:scripting/python: always treat the highwatermark as opaque (bug #9508)Stefan Metzmacher2013-01-013-3/+3
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* selftest/flapping: more samba4.rpc.samr.large-dc.two subtests are flakeyStefan Metzmacher2013-01-011-1/+1
| | | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Jan 1 18:47:42 CET 2013 on sn-devel-104
* Happy New Year 2013Stefan Metzmacher2013-01-012-2/+2
| | | | Signed-off-by: Stefan Metzmacher <metze@samba.org>
* subunit: Update to latest upstream version.Jelmer Vernooij2012-12-2713-12/+101
| | | | | Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org> Autobuild-Date(master): Thu Dec 27 21:08:32 CET 2012 on sn-devel-104
* testtools: Update to latest upstream version.Jelmer Vernooij2012-12-2719-63/+503
|
* lib/param: use the correct path names againStefan Metzmacher2012-12-271-5/+5
| | | | | | | | | | | This fixes a regression which was introduced by commit 5b1d95046c8ea624419d94dd7d9e2785ba86f556. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Dec 27 19:19:55 CET 2012 on sn-devel-104
* selftest/flapping: mark samba4.rpc.samr.large-dc.two as knownfailStefan Metzmacher2012-12-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | This is really flakey lately: https://git.samba.org/autobuild.flakey/2012-12-27-1533/samba.stdout ... https://git.samba.org/autobuild.flakey/2012-12-10-2338/samba.stdout ... https://git.samba.org/autobuild.flakey/2012-12-09-0135/samba.stdout ... https://git.samba.org/autobuild.flakey/2012-12-06-0333/samba.stdout ... https://git.samba.org/autobuild.flakey/2012-12-05-0731/samba.stdout ... https://git.samba.org/autobuild.flakey/2012-12-03-0334/samba.stdout ... https://git.samba.org/autobuild.flakey/2012-12-02-1532/samba.stdout Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu Dec 27 17:36:07 CET 2012 on sn-devel-104
* selftest.pl: Fix typo 'snprintf' -> 'sprintf'.Jelmer Vernooij2012-12-261-1/+1
| | | | | Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org> Autobuild-Date(master): Wed Dec 26 22:35:12 CET 2012 on sn-devel-104
* wafsamba: python-config is not always a script.Jelmer Vernooij2012-12-261-1/+1
|
* Recent coverity changes added directory_create_or_exist() checks to many ↵Jeremy Allison2012-12-222-0/+13
| | | | | | | | | | | | | directories. These may not be needed, but in the meantime - ensure "make test" works again by chmod'ing the created test directories from 0777 to 0755. Reviewed-By: Andrew Bartlett <abartlet@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Dec 22 02:08:33 CET 2012 on sn-devel-104
* s3-prefork: Directly fail if tevent_req_is_unix_error() fails.Andreas Schneider2012-12-211-1/+3
| | | | | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Fri Dec 21 15:38:19 CET 2012 on sn-devel-104
* s3-libsmb: Remove check if array is NULL.Andreas Schneider2012-12-211-1/+2
| | | | | | | | | | rdata is an array with data. rdlength defines how big rdata is. So if rdlength is not set we have a big problem. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-rpc_server: Fix username and remote check.Andreas Schneider2012-12-211-2/+2
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4-libcli: Use a do-while loop.Andreas Schneider2012-12-211-3/+3
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-lib: Cleanup transfer_file_internal() a bit.Andreas Schneider2012-12-211-2/+6
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* libgpo: Make it clear that we want to fall trough here.Andreas Schneider2012-12-211-0/+2
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4-dsdb: Make it clear that we want to fall trough here.Andreas Schneider2012-12-211-0/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-rpc_server: Make it clear we want to fall trough here.Andreas Schneider2012-12-211-0/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-lib: Make it clear that we want to fall trough here.Andreas Schneider2012-12-211-0/+2
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-netapi: Add missing break in NetUserSetInfo_r().Andreas Schneider2012-12-211-0/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-libsmb: Fix a possible null pointer dereference.Andreas Schneider2012-12-211-1/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-rpc_server: Fix null pointer derefs in rpc_pipe_open_interface().Andreas Schneider2012-12-211-5/+7
| | | | | | | Found by Coverity and asn ;) Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-winbind: Fix null pointer dereference in store_memory_creds().Andreas Schneider2012-12-211-4/+4
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-vfs: Fix a null pointer deferference in vfs_media_harmony.Andreas Schneider2012-12-211-1/+3
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-rpc_server: Fix a possible null pointer dereference.Andreas Schneider2012-12-211-1/+2
| | | | | | | | | This variable can be set to NULL in an earlier function call. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-vfs: Fix typo in readonly_connect().Andreas Schneider2012-12-211-1/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* libcli: Fix smb2cli_ioctl_send() if clause.Andreas Schneider2012-12-211-1/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* libwbclient: Fix null check in process_domain_info_string().Andreas Schneider2012-12-211-5/+0
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-rpc_server: Fix useless check if we still have a valid string.Andreas Schneider2012-12-211-3/+3
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-libads: Fix copy&paste error in ads_keytab_add_entry().Andreas Schneider2012-12-211-1/+1
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-lib: Fix push_ucs2() for-loop.Andreas Schneider2012-12-211-2/+2
| | | | | | | | | | | | ret is a bool and size is what we are looking for here, else the statement can never be true. Jeremy please check! Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s3-tldap: Fix dead code in tldap_sasl_bind_send().Andreas Schneider2012-12-211-1/+1
| | | | | | | | | dn can't be NULL cause it is set to "" in that case. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* s4-librpc: Remove dead code in smb_send_request().Andreas Schneider2012-12-211-4/+0
| | | | | | | | | If trigger_read we return earlier. Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* krb5_wrap: Remove dead code in smb_krb5_renew_ticket().Andreas Schneider2012-12-211-7/+2
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* nsswitch: Fix wbclient BAIL macros.Andreas Schneider2012-12-211-2/+2
| | | | | | | | | | | In the code you normally use: BAIL_ON_WBC_ERROR; but the last ; is statement never reached, so dead code. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
* libcli: Check schannel state return value of tdb_transaction_commit().Andreas Schneider2012-12-211-1/+5
| | | | | | | Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
generated by cgit (git 2.34.1) at 2025-09-26 19:50:12 +0000