summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndreas Schneider <asn@samba.org>2012-12-19 11:20:50 +0100
committerGünther Deschner <gd@samba.org>2012-12-21 13:56:01 +0100
commit56eb4ab5f6280aa40c0e0edefad7f965b3f02a4a (patch)
tree50ab65a5d92569fd8a5e8e9acb06e708f2357083
parentbc3edaa6ad1a511075a97eab0bbb19a26b2288d2 (diff)
downloadsamba-56eb4ab5f6280aa40c0e0edefad7f965b3f02a4a.tar.gz
samba-56eb4ab5f6280aa40c0e0edefad7f965b3f02a4a.tar.xz
samba-56eb4ab5f6280aa40c0e0edefad7f965b3f02a4a.zip
s3-rpc_server: Fix username and remote check.
Found by Coverity. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
-rw-r--r--source3/rpc_server/wkssvc/srv_wkssvc_nt.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/source3/rpc_server/wkssvc/srv_wkssvc_nt.c b/source3/rpc_server/wkssvc/srv_wkssvc_nt.c
index ada83ea18d..daa44e9e28 100644
--- a/source3/rpc_server/wkssvc/srv_wkssvc_nt.c
+++ b/source3/rpc_server/wkssvc/srv_wkssvc_nt.c
@@ -183,8 +183,8 @@ static struct dom_usr *get_domain_userlist(TALLOC_CTX *mem_ctx)
}
for (i=num_users=0; i<num_sessions; i++) {
- if (!session_list[i].username
- || !session_list[i].remote_machine) {
+ if (session_list[i].username[0] == '\0' ||
+ session_list[i].remote_machine[0] == '\0') {
continue;
}
p = strpbrk(session_list[i].remote_machine, "./");