diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2014-09-02 09:48:34 +1200 |
|---|---|---|
| committer | Matthieu Patou <mat@samba.org> | 2014-10-13 08:28:14 +0200 |
| commit | bf0db7ecc99482784f4cfc77f6603566f581622e (patch) | |
| tree | 6faa591177cf1ccc17db24d2408f0bfaddbcc4e9 /source4 | |
| parent | f593835e54648621a46600bde7866e629718ebf4 (diff) | |
dsdb: Do not attempt to return beyond the end of the password history array
Found by AddressSanitizer
Change-Id: I82e35aea60726053c79510ba8ed3eedfaf553eb7
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Matthieu Patou <mat@matws.net>
Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Mon Oct 13 08:28:15 CEST 2014 on sn-devel-104
Diffstat (limited to 'source4')
| -rw-r--r-- | source4/dsdb/common/util.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source4/dsdb/common/util.c b/source4/dsdb/common/util.c index 409191d12b..a892f2da0f 100644 --- a/source4/dsdb/common/util.c +++ b/source4/dsdb/common/util.c @@ -570,7 +570,7 @@ NTSTATUS samdb_result_passwords_from_history(TALLOC_CTX *mem_ctx, if (nt_pwd) { unsigned int num_nt; num_nt = samdb_result_hashes(mem_ctx, msg, "ntPwdHistory", &ntPwdHash); - if (num_nt < idx) { + if (num_nt <= idx) { *nt_pwd = NULL; } else { *nt_pwd = &ntPwdHash[idx]; @@ -583,7 +583,7 @@ NTSTATUS samdb_result_passwords_from_history(TALLOC_CTX *mem_ctx, if (lpcfg_lanman_auth(lp_ctx)) { unsigned int num_lm; num_lm = samdb_result_hashes(mem_ctx, msg, "lmPwdHistory", &lmPwdHash); - if (num_lm < idx) { + if (num_lm <= idx) { *lm_pwd = NULL; } else { *lm_pwd = &lmPwdHash[idx]; |