diff options
| author | Volker Lendecke <vl@samba.org> | 2015-03-05 21:17:31 +0100 |
|---|---|---|
| committer | David Disseldorp <ddiss@samba.org> | 2015-03-06 17:38:09 +0100 |
| commit | 90d03a65bcb2aae262ad113da420ae63bdf5b4b1 (patch) | |
| tree | 858c2dd85c38b56d7cbbe54fee34543b4fefc2de /source4 | |
| parent | 87b7a7dbaa28b29dac316b8b6d953c231529e372 (diff) | |
| download | samba-90d03a65bcb2aae262ad113da420ae63bdf5b4b1.tar.gz samba-90d03a65bcb2aae262ad113da420ae63bdf5b4b1.tar.xz samba-90d03a65bcb2aae262ad113da420ae63bdf5b4b1.zip | |
heimdal: Fix CID 1273430 Double free
I think Coverity is right here: Before the preceding call to
krb5_make_principal we already krb5_free_principal(ctx, tmp_creds.server)
without wiping out tmp_creds.server. The call to krb5_make_principal only
stores something fresh when it also returns 0 a.k.a. success.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Mar 6 17:38:09 CET 2015 on sn-devel-104
Diffstat (limited to 'source4')
| -rw-r--r-- | source4/heimdal/lib/krb5/get_cred.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/source4/heimdal/lib/krb5/get_cred.c b/source4/heimdal/lib/krb5/get_cred.c index 51550daa4c..29ab6eaaa7 100644 --- a/source4/heimdal/lib/krb5/get_cred.c +++ b/source4/heimdal/lib/krb5/get_cred.c @@ -839,7 +839,6 @@ get_cred_kdc_capath_worker(krb5_context context, ret = krb5_make_principal(context, &tmp_creds.server, tgt_inst, KRB5_TGS_NAME, server_realm, NULL); if(ret) { - krb5_free_principal(context, tmp_creds.server); krb5_free_principal(context, tmp_creds.client); return ret; } |