summaryrefslogtreecommitdiffstats
path: root/source4
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2014-09-02 14:38:11 +1200
committerAndrew Bartlett <abartlet@samba.org>2014-09-11 08:50:16 +0200
commit01d4c0e804e0c10fe6acfbdbe6747dcc5df6abc9 (patch)
tree59dfb32be13a3d9f5eef867a56ab50a55d1156c7 /source4
parent1c00533bc0695117cc234d272ec3e0c8c19d3932 (diff)
torture: Provide enough space for test EA name in raw.eas test
The issue is that previously bad_ea_name[5] was the last element on the array, and so when we later did a strlen() on it, we read past the end of the stack array. We need bad_ea_name[5] to be the second-last element, followed by the \0 placed there by the strlcpy(). Found by AddressSanitizer Change-Id: I871c08200aa2591c612dfa44da92b83132f83d88 Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Kamen Mazdrashki <kamenim@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Sep 11 08:50:16 CEST 2014 on sn-devel-104
Diffstat (limited to 'source4')
-rw-r--r--source4/torture/raw/eas.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/torture/raw/eas.c b/source4/torture/raw/eas.c
index 95a55d1ecf..15bfb2f072 100644
--- a/source4/torture/raw/eas.c
+++ b/source4/torture/raw/eas.c
@@ -51,7 +51,7 @@ static bool test_eas(struct smbcli_state *cli, struct torture_context *tctx)
union smb_open io;
const char *fname = BASEDIR "\\ea.txt";
bool ret = true;
- char bad_ea_name[6];
+ char bad_ea_name[7];
int i;
int fnum = -1;