diff options
| author | Garming Sam <garming@catalyst.net.nz> | 2014-02-14 17:46:40 +1300 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2014-03-05 16:33:22 +0100 |
| commit | 856c74e013eaa53902479b771e6c0cf1fea67745 (patch) | |
| tree | 78aa23235189f68c5bed7676cef6639ffaff01d8 /source4/wrepl_server | |
| parent | 4c9e0d5addd626769123299b593ec937ee52a0b5 (diff) | |
| download | samba-856c74e013eaa53902479b771e6c0cf1fea67745.tar.gz samba-856c74e013eaa53902479b771e6c0cf1fea67745.tar.xz samba-856c74e013eaa53902479b771e6c0cf1fea67745.zip | |
Remove NT_STATUS_IS_ERR_RETURN macro from the codebase.
Following the current coding guidelines, it is considered bad practice to return from
within a macro and change control flow as they look like normal function calls.
Change-Id: I39b07b3a799331a5faa968629aa95b836cb78600
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Diffstat (limited to 'source4/wrepl_server')
| -rw-r--r-- | source4/wrepl_server/wrepl_in_connection.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/source4/wrepl_server/wrepl_in_connection.c b/source4/wrepl_server/wrepl_in_connection.c index 251e5a0247..b8e9a16dc2 100644 --- a/source4/wrepl_server/wrepl_in_connection.c +++ b/source4/wrepl_server/wrepl_in_connection.c @@ -65,7 +65,9 @@ static NTSTATUS wreplsrv_process(struct wreplsrv_in_connection *wrepl_conn, } status = wreplsrv_in_call(call); - NT_STATUS_IS_ERR_RETURN(status); + if (NT_STATUS_IS_ERR(status)) { + return status; + } if (!NT_STATUS_IS_OK(status)) { /* w2k just ignores invalid packets, so we do */ DEBUG(10,("Received WINS-Replication packet was invalid, we just ignore it\n")); |