summaryrefslogtreecommitdiffstats
path: root/source4/scripting/bin
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2014-07-08 00:05:03 +0200
committerStefan Metzmacher <metze@samba.org>2014-08-26 09:13:06 +0200
commitb13974048b74c60028d8387eb7fe4fc7734f0a91 (patch)
tree0fa426fe6b8cfb11a1df5218eb860aa213b10d18 /source4/scripting/bin
parent25ec8e8656f66fe51a0d48718cdcfd8b209f6ca0 (diff)
downloadsamba-b13974048b74c60028d8387eb7fe4fc7734f0a91.tar.gz
samba-b13974048b74c60028d8387eb7fe4fc7734f0a91.tar.xz
samba-b13974048b74c60028d8387eb7fe4fc7734f0a91.zip
s4:samba_dnsupdate: don't try to be smart when verifying NS records
We can't rely on the DNS delegation to be correct in the parent domain. What we really want is to check if we already have registered ourself as a NS record in our own domain. Bug: https://bugzilla.samba.org/show_bug.cgi?id=9831 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'source4/scripting/bin')
-rwxr-xr-xsource4/scripting/bin/samba_dnsupdate19
1 files changed, 0 insertions, 19 deletions
diff --git a/source4/scripting/bin/samba_dnsupdate b/source4/scripting/bin/samba_dnsupdate
index 9c7c5e232c..0d001ac914 100755
--- a/source4/scripting/bin/samba_dnsupdate
+++ b/source4/scripting/bin/samba_dnsupdate
@@ -203,25 +203,6 @@ def check_dns_name(d):
return False
resolver = dns.resolver.Resolver()
- if d.type == "NS":
- # we need to lookup the nameserver for the parent domain,
- # and use that to check the NS record
- parent_domain = '.'.join(normalised_name.split('.')[1:])
- try:
- ans = resolver.query(parent_domain, 'NS')
- except dns.exception.DNSException:
- if opts.verbose:
- print "Failed to find parent NS for %s" % d
- return False
- nameservers = set()
- for i in range(len(ans)):
- try:
- ns = resolver.query(str(ans[i]), 'A')
- except dns.exception.DNSException:
- continue
- for j in range(len(ns)):
- nameservers.add(str(ns[j]))
- d.nameservers = list(nameservers)
try:
if getattr(d, 'nameservers', None):