diff options
| author | Garming Sam <garming@catalyst.net.nz> | 2014-01-17 10:30:37 +1300 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2014-02-20 10:11:06 +1300 |
| commit | 1fb1f6bc0dad00d1eb2d1e2aff34e9d3b2714421 (patch) | |
| tree | 93ec165ad1423688666d46399c1890a17cb99b15 /source4/rpc_server/srvsvc | |
| parent | bce62e600085270f26053882c5a4e35f5fe4fb5e (diff) | |
| download | samba-1fb1f6bc0dad00d1eb2d1e2aff34e9d3b2714421.tar.gz samba-1fb1f6bc0dad00d1eb2d1e2aff34e9d3b2714421.tar.xz samba-1fb1f6bc0dad00d1eb2d1e2aff34e9d3b2714421.zip | |
lib/param: handle non-constant strings properly by passing in a memory context
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Change-Id: Ic6bb1c709defd2b0f35fc7b877da0badca385776
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@samba.org>
Diffstat (limited to 'source4/rpc_server/srvsvc')
| -rw-r--r-- | source4/rpc_server/srvsvc/dcesrv_srvsvc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source4/rpc_server/srvsvc/dcesrv_srvsvc.c b/source4/rpc_server/srvsvc/dcesrv_srvsvc.c index 6521aea503..4fd6d32e30 100644 --- a/source4/rpc_server/srvsvc/dcesrv_srvsvc.c +++ b/source4/rpc_server/srvsvc/dcesrv_srvsvc.c @@ -1464,7 +1464,7 @@ static WERROR dcesrv_srvsvc_NetSrvGetInfo(struct dcesrv_call_state *dce_call, TA info101->version_major = server_info->version_major; info101->version_minor = server_info->version_minor; info101->server_type = dcesrv_common_get_server_type(mem_ctx, dce_call->event_ctx, dce_ctx); - info101->comment = talloc_strdup(mem_ctx, lpcfg_server_string(dce_ctx->lp_ctx)); + info101->comment = lpcfg_server_string(dce_ctx->lp_ctx, mem_ctx); W_ERROR_HAVE_NO_MEMORY(info101->comment); r->out.info->info101 = info101; @@ -1484,7 +1484,7 @@ static WERROR dcesrv_srvsvc_NetSrvGetInfo(struct dcesrv_call_state *dce_call, TA info102->version_major = server_info->version_major; info102->version_minor = server_info->version_minor; info102->server_type = dcesrv_common_get_server_type(mem_ctx, dce_call->event_ctx, dce_ctx); - info102->comment = talloc_strdup(mem_ctx, lpcfg_server_string(dce_ctx->lp_ctx)); + info102->comment = lpcfg_server_string(dce_ctx->lp_ctx, mem_ctx); W_ERROR_HAVE_NO_MEMORY(info102->comment); info102->users = dcesrv_common_get_users(mem_ctx, dce_ctx); |