summaryrefslogtreecommitdiffstats
path: root/source4/libcli/ldap/ldap_controls.c
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2014-09-22 16:08:26 -0700
committerJeremy Allison <jra@samba.org>2014-09-26 03:15:00 +0200
commit69a7e3cfdc8dbba9c8dcfdfae82d2894c7247e15 (patch)
tree33662e9b0a052d1063a689d2626c7a1ba81a2178 /source4/libcli/ldap/ldap_controls.c
parentb1a1f691c8d1b6b1064a5033c81451e5c606b9f4 (diff)
downloadsamba-69a7e3cfdc8dbba9c8dcfdfae82d2894c7247e15.tar.gz
samba-69a7e3cfdc8dbba9c8dcfdfae82d2894c7247e15.tar.xz
samba-69a7e3cfdc8dbba9c8dcfdfae82d2894c7247e15.zip
s4: libcli: ldap message - Ensure all asn1_XX returns are checked.
Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Ronnie Sahlberg <ronniesahlberg@gmail.com> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Sep 26 03:15:00 CEST 2014 on sn-devel-104
Diffstat (limited to 'source4/libcli/ldap/ldap_controls.c')
-rw-r--r--source4/libcli/ldap/ldap_controls.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/source4/libcli/ldap/ldap_controls.c b/source4/libcli/ldap/ldap_controls.c
index 1e67a0124a..f910acba38 100644
--- a/source4/libcli/ldap/ldap_controls.c
+++ b/source4/libcli/ldap/ldap_controls.c
@@ -1197,10 +1197,10 @@ static bool decode_openldap_dereference(void *mem_ctx, DATA_BLOB in, void *_out)
if (!asn1_start_tag(data, ASN1_CONTEXT(0))) {
return false;
}
-
- ldap_decode_attribs_bare(r, data, &r[i]->attributes,
- &r[i]->num_attributes);
-
+ if (!ldap_decode_attribs_bare(r, data, &r[i]->attributes,
+ &r[i]->num_attributes)) {
+ return false;
+ }
if (!asn1_end_tag(data)) {
return false;
}