diff options
| author | Wilco Baan Hofman <wilco@baanhofman.nl> | 2010-10-03 06:19:12 +0200 |
|---|---|---|
| committer | Jelmer Vernooij <jelmer@samba.org> | 2010-10-03 15:31:38 +0200 |
| commit | a8adadbe5b5118d6768953d35b21475b06474412 (patch) | |
| tree | 2df3338b3ecd28dd4e0b784b81334590bac86d4e /source4/lib/registry | |
| parent | 6e881dd86ac9e99fed2091b8ba3d677200d8fc3b (diff) | |
| download | samba-a8adadbe5b5118d6768953d35b21475b06474412.tar.gz samba-a8adadbe5b5118d6768953d35b21475b06474412.tar.xz samba-a8adadbe5b5118d6768953d35b21475b06474412.zip | |
Fix issues addressed by Jelmer:
* Add a comment about why the reg_strhex_to_data_blob was added
* Fix int which should've been a boolean
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Diffstat (limited to 'source4/lib/registry')
| -rw-r--r-- | source4/lib/registry/regf.c | 4 | ||||
| -rw-r--r-- | source4/lib/registry/util.c | 5 |
2 files changed, 7 insertions, 2 deletions
diff --git a/source4/lib/registry/regf.c b/source4/lib/registry/regf.c index 872a9050bf..5ca7b7c66c 100644 --- a/source4/lib/registry/regf.c +++ b/source4/lib/registry/regf.c @@ -52,7 +52,7 @@ struct regf_data { time_t last_write; }; -static WERROR regf_save_hbin(struct regf_data *data, int flush); +static WERROR regf_save_hbin(struct regf_data *data, bool flush); struct regf_key_data { struct hive_key key; @@ -1973,7 +1973,7 @@ static WERROR regf_set_value(struct hive_key *key, const char *name, return regf_save_hbin(private_data->hive, 0); } -static WERROR regf_save_hbin(struct regf_data *regf, int flush) +static WERROR regf_save_hbin(struct regf_data *regf, bool flush) { struct tdr_push *push = tdr_push_init(regf); unsigned int i; diff --git a/source4/lib/registry/util.c b/source4/lib/registry/util.c index 29417f86d3..d1e953951f 100644 --- a/source4/lib/registry/util.c +++ b/source4/lib/registry/util.c @@ -78,6 +78,11 @@ _PUBLIC_ char *reg_val_description(TALLOC_CTX *mem_ctx, reg_val_data_string(mem_ctx, data_type, data)); } +/* + * This implements reading hex bytes that include comma's. + * It was previously handled by strhex_to_data_blob, but that did not cover + * the format used by windows. + */ static DATA_BLOB reg_strhex_to_data_blob(TALLOC_CTX *mem_ctx, const char *str) { DATA_BLOB ret; |