summaryrefslogtreecommitdiffstats
path: root/source3/smbd/smb2_close.c
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2015-02-19 18:50:45 -0800
committerJeremy Allison <jra@samba.org>2015-02-20 20:54:18 +0100
commita6008b2de7b2974073f38a1df88aacc27d3c6f57 (patch)
tree491ebe28126f716f00890d6fdbc6043fcf108efb /source3/smbd/smb2_close.c
parent4a8c6988e349a4f714f3052ebf3f96f801d3c11f (diff)
downloadsamba-a6008b2de7b2974073f38a1df88aacc27d3c6f57.tar.gz
samba-a6008b2de7b2974073f38a1df88aacc27d3c6f57.tar.xz
samba-a6008b2de7b2974073f38a1df88aacc27d3c6f57.zip
s3: smbd: SMB2 close. If a file has delete on close, store the return info before deleting.
If we delete the file on close, the stat after the close will fail so we fail to return the attributes requested. Bug 11104 - SMB2/SMB3 close response does not include attributes when requested. https://bugzilla.samba.org/show_bug.cgi?id=11104 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Steve French <sfrench@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Feb 20 20:54:18 CET 2015 on sn-devel-104
Diffstat (limited to 'source3/smbd/smb2_close.c')
-rw-r--r--source3/smbd/smb2_close.c20
1 files changed, 20 insertions, 0 deletions
diff --git a/source3/smbd/smb2_close.c b/source3/smbd/smb2_close.c
index 755a4b69f3..ed53e1be0a 100644
--- a/source3/smbd/smb2_close.c
+++ b/source3/smbd/smb2_close.c
@@ -237,6 +237,26 @@ static NTSTATUS smbd_smb2_close(struct smbd_smb2_request *req,
return NT_STATUS_NO_MEMORY;
}
+ if ((in_flags & SMB2_CLOSE_FLAGS_FULL_INFORMATION) &&
+ (fsp->initial_delete_on_close || fsp->delete_on_close)) {
+ /*
+ * We might be deleting the file. Ensure we
+ * return valid data from before the file got
+ * removed.
+ */
+ setup_close_full_information(conn,
+ smb_fname,
+ posix_open,
+ out_creation_ts,
+ out_last_access_ts,
+ out_last_write_ts,
+ out_change_ts,
+ &flags,
+ &allocation_size,
+ &file_size,
+ &dos_attrs);
+ }
+
status = close_file(smbreq, fsp, NORMAL_CLOSE);
if (!NT_STATUS_IS_OK(status)) {
DEBUG(5,("smbd_smb2_close: close_file[%s]: %s\n",