diff options
| author | Jeremy Allison <jra@samba.org> | 2014-08-25 17:11:58 -0700 |
|---|---|---|
| committer | David Disseldorp <ddiss@samba.org> | 2014-09-16 01:56:54 +0200 |
| commit | 0519088c53b201b7ca1f144f3f2da052c612c0e7 (patch) | |
| tree | 59d41b8d7869877d0c8579fb2663817a618f9f84 /source3/smbd/proto.h | |
| parent | c7b89bb9e5531be378c1b71fa7165f3ce74c83bb (diff) | |
| download | samba-0519088c53b201b7ca1f144f3f2da052c612c0e7.tar.gz samba-0519088c53b201b7ca1f144f3f2da052c612c0e7.tar.xz samba-0519088c53b201b7ca1f144f3f2da052c612c0e7.zip | |
s3: smbd: Change the function signature of srvstr_push() from returning a length to returning an NTSTATUS with a length param.
srvstr_push_fn() now returns an NTSTATUS reporting any
string conversion failure.
We need to get serious about returning character set conversion errors
inside smbd.
Bug 10775 - smbd crashes when accessing garbage filenames
https://bugzilla.samba.org/show_bug.cgi?id=10775
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Diffstat (limited to 'source3/smbd/proto.h')
| -rw-r--r-- | source3/smbd/proto.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source3/smbd/proto.h b/source3/smbd/proto.h index f2b5888491..3a5ebcce08 100644 --- a/source3/smbd/proto.h +++ b/source3/smbd/proto.h @@ -1011,8 +1011,8 @@ bool is_share_read_only_for_token(const char *username, /* The following definitions come from smbd/srvstr.c */ -size_t srvstr_push_fn(const char *base_ptr, uint16 smb_flags2, void *dest, - const char *src, int dest_len, int flags); +NTSTATUS srvstr_push_fn(const char *base_ptr, uint16 smb_flags2, void *dest, + const char *src, int dest_len, int flags, size_t *ret_len); ssize_t message_push_string(uint8 **outbuf, const char *str, int flags); /* The following definitions come from smbd/statcache.c */ |