summaryrefslogtreecommitdiffstats
path: root/source3/pam_smbpass
diff options
context:
space:
mode:
authorAndreas Schneider <asn@samba.org>2015-01-22 09:51:10 +0100
committerJeremy Allison <jra@samba.org>2015-01-22 20:29:07 +0100
commit016bee95e39db09f8d9df99ab467f574cecca946 (patch)
tree0637a6a244465bff6eca38fb9b4dc5219ce26b6c /source3/pam_smbpass
parentbc0768c9645251d62d8131987000d5111d84c948 (diff)
downloadsamba-016bee95e39db09f8d9df99ab467f574cecca946.tar.gz
samba-016bee95e39db09f8d9df99ab467f574cecca946.tar.xz
samba-016bee95e39db09f8d9df99ab467f574cecca946.zip
s3-pam_smbpass: Check the return code of secrets_init().
This fixes a coverity warning. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'source3/pam_smbpass')
-rw-r--r--source3/pam_smbpass/support.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/source3/pam_smbpass/support.c b/source3/pam_smbpass/support.c
index f7fec208bc..7c96804af6 100644
--- a/source3/pam_smbpass/support.c
+++ b/source3/pam_smbpass/support.c
@@ -170,6 +170,7 @@ unsigned int set_ctrl(pam_handle_t *pamh,
int i = 0;
const char *service_file = NULL;
unsigned int ctrl;
+ bool ok;
ctrl = SMB_DEFAULTS; /* the default selection of options */
@@ -210,7 +211,10 @@ unsigned int set_ctrl(pam_handle_t *pamh,
_log_err(pamh, LOG_ERR, "Error loading service file %s", service_file);
}
- secrets_init();
+ ok = secrets_init();
+ if (!ok) {
+ _log_err(pamh, LOG_ERR, "Error loading secrets database");
+ }
if (lp_null_passwords()) {
set( SMB__NULLOK, ctrl );