diff options
author | Michael Adam <obnox@samba.org> | 2014-07-09 23:56:34 +0200 |
---|---|---|
committer | Christof Schmitt <cs@samba.org> | 2014-07-13 08:59:11 +0200 |
commit | 26290ba8a45d4caf935995284a111ec57f77cfd7 (patch) | |
tree | 6499763fe17620e28a1d9855b0d376d38aea9c00 /source3/modules/vfs_gpfs.c | |
parent | 31e67507144aae8d5a8ec49587ac89d2d94636f0 (diff) | |
download | samba-26290ba8a45d4caf935995284a111ec57f77cfd7.tar.gz samba-26290ba8a45d4caf935995284a111ec57f77cfd7.tar.xz samba-26290ba8a45d4caf935995284a111ec57f77cfd7.zip |
s3:vfs:gpfs: log when winAttr-garbage is detected (by heuristics) in is_offline
In is_offline(), check whether the winAttrs are filled with bits
outside 0xFFFF and log it prominently: Since GPFS only
fills 0xFFFF, this could be due to an uninitialized buffer
(or another vfs module filling vfs_private? ...).
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Diffstat (limited to 'source3/modules/vfs_gpfs.c')
-rw-r--r-- | source3/modules/vfs_gpfs.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c index 9fcce78a68..c94e4e829e 100644 --- a/source3/modules/vfs_gpfs.c +++ b/source3/modules/vfs_gpfs.c @@ -1819,6 +1819,11 @@ static bool vfs_gpfs_is_offline(struct vfs_handle_struct *handle, return -1; } + if (VALID_STAT(*sbuf) && (sbuf->vfs_private & ~0x0FFFF) != 0) { + DEBUG(0, ("vfs_gpfs_is_offline: valid stat but " + "uninitialized winAttrs (0x%08x)?\n", + (uint32_t)sbuf->vfs_private)); + } { int ret; ret = get_gpfs_winattrs(path, &attrs); |