summaryrefslogtreecommitdiffstats
path: root/source3/modules/vfs_default.c
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2014-11-05 12:18:31 +0000
committerJeremy Allison <jra@samba.org>2014-12-09 04:12:09 +0100
commita5a5326152a090e737201612f5e29a7ecc457c85 (patch)
tree9486a80df63c58bab19c0ec2d63a83d58e532f74 /source3/modules/vfs_default.c
parentde4a1c90a70b31f99e987fa109683862bd0823d1 (diff)
downloadsamba-a5a5326152a090e737201612f5e29a7ecc457c85.tar.gz
samba-a5a5326152a090e737201612f5e29a7ecc457c85.tar.xz
samba-a5a5326152a090e737201612f5e29a7ecc457c85.zip
notify_inotify: inotify_watch now takes a mem_ctx
This will make it easier to integrate into proper memory hierarchies. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'source3/modules/vfs_default.c')
-rw-r--r--source3/modules/vfs_default.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/source3/modules/vfs_default.c b/source3/modules/vfs_default.c
index eaa1c2be4f..5634cc0fe9 100644
--- a/source3/modules/vfs_default.c
+++ b/source3/modules/vfs_default.c
@@ -2123,7 +2123,14 @@ static NTSTATUS vfswrap_notify_watch(vfs_handle_struct *vfs_handle,
if (!lp_parm_bool(-1, "notify", "inotify", True)) {
return NT_STATUS_INVALID_SYSTEM_SERVICE;
}
- ret = inotify_watch(ctx, path, filter, subdir_filter,
+ /*
+ * "ctx->private_data" is not obvious as a talloc context
+ * here. Without modifying the VFS we don't have a mem_ctx
+ * available here, and ctx->private_data was used by
+ * inotify_watch before it got a real talloc parent.
+ */
+ ret = inotify_watch(ctx->private_data, ctx,
+ path, filter, subdir_filter,
callback, private_data, handle);
if (ret != 0) {
return map_nt_error_from_unix(ret);