summaryrefslogtreecommitdiffstats
path: root/lib/ldb/common
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2013-12-06 15:58:02 -0800
committerMichael Adam <obnox@samba.org>2013-12-07 11:10:47 +0100
commit966667abbef2da09b4a42725a86f3202b88e3966 (patch)
tree556386f0fffe1c04bf3f31a1ca037cbc970f06d6 /lib/ldb/common
parentf6ac6f20540f81257e1f180454b6a2c1239e85fa (diff)
downloadsamba-966667abbef2da09b4a42725a86f3202b88e3966.tar.gz
samba-966667abbef2da09b4a42725a86f3202b88e3966.tar.xz
samba-966667abbef2da09b4a42725a86f3202b88e3966.zip
ldb: bad if test in ldb_comparison_fold()
Found by David Binderman <dcb314@hotmail.com> BUG: https://bugzilla.samba.org/show_bug.cgi?id=10305 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Sat Dec 7 11:10:47 CET 2013 on sn-devel-104
Diffstat (limited to 'lib/ldb/common')
-rw-r--r--lib/ldb/common/attrib_handlers.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/ldb/common/attrib_handlers.c b/lib/ldb/common/attrib_handlers.c
index daeb422aca..4b94d392cc 100644
--- a/lib/ldb/common/attrib_handlers.c
+++ b/lib/ldb/common/attrib_handlers.c
@@ -254,7 +254,7 @@ int ldb_comparison_fold(struct ldb_context *ldb, void *mem_ctx,
if (n2 == 0 && n1 != 0) {
return (int)toupper(*s1);
}
- if (n2 == 0 && n2 == 0) {
+ if (n1 == 0 && n2 == 0) {
return 0;
}
return (int)toupper(*s1) - (int)toupper(*s2);