ctdb-logging: Remove log ringbuffer

As far as we know, nobody uses this and it just complicates the
logging subsystem.

Remove all ringbuffer code and documentation.  Update the local
daemons startup code correspondingly.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>

3 files changed, 0 insertions, 67 deletions

diff --git a/ctdb/doc/ctdb.1.xml b/ctdb/doc/ctdb.1.xml
index 87840cd45e..efa5d85326 100644
--- a/ctdb/doc/ctdb.1.xml
+++ b/ctdb/doc/ctdb.1.xml
@@ -1185,44 +1185,6 @@ dbid:0xb775fff6 name:secrets.tdb path:/var/ctdb/persistent/secrets.tdb.0 PERSIST
     </refsect2>
 
     <refsect2>
-      <title>getlog [<parameter>LEVEL</parameter>] [recoverd]</title>
-      <para>
-	In addition to the normal logging to a log file, CTDB also
-	keeps a in-memory ringbuffer containing the most recent log
-	entries for all log levels (except DEBUG).
-      </para>
-      <para>
-	This is useful since it allows for keeping continuous logs to a file
-	at a reasonable non-verbose level, but shortly after an incident has
-	occured, a much more detailed log can be pulled from memory. This
-	can allow you to avoid having to reproduce an issue due to the
-	on-disk logs being of insufficient detail.
-      </para>
-      <para>
-	This command extracts all messages of level or lower log level
-	from memory and prints it to the screen.  The level is not
-	specified it defaults to NOTICE.
-      </para>
-      <para>
-	By default, logs are extracted from the main CTDB daemon.  If
-	the recoverd option is given then logs are extracted from the
-	recovery daemon.
-      </para>
-    </refsect2>
-
-    <refsect2>
-      <title>clearlog [recoverd]</title>
-      <para>
-	This command clears the in-memory logging ringbuffer.
-      </para>
-      <para>
-	By default, logs are cleared in the main CTDB daemon.  If the
-	recoverd option is given then logs are cleared in the recovery
-	daemon.
-      </para>
-    </refsect2>
-
-    <refsect2>
       <title>setdbreadonly <parameter>DB</parameter></title>
       <para>
 	This command will enable the read-only record support for a
diff --git a/ctdb/doc/ctdbd.1.xml b/ctdb/doc/ctdbd.1.xml
index ab222bc2d6..20f2d8bb85 100644
--- a/ctdb/doc/ctdbd.1.xml
+++ b/ctdb/doc/ctdbd.1.xml
@@ -137,25 +137,6 @@
       </varlistentry>
 
       <varlistentry>
-	<term>--log-ringbuf-size=<parameter>NUM</parameter></term>
-	<listitem>
-	  <para>
-	    Set the size of the log ringbuffer to NUM entries.
-	  </para>
-	  <para>
-	    CTDB uses an in-memory ringbuffer containing NUM most
-	    recent log entries for all log levels (except DEBUG).  The
-	    ringbugger can be useful for extracting detailed logs even
-	    if some entries are not logged to the regular logs.
-	  </para>
-	  <para>
-	    Use the <command>ctdb getlog</command> command to retrieve
-	    log entries from the ringbuffer.
-	  </para>
-	</listitem>
-      </varlistentry>
-
-      <varlistentry>
 	<term>--lvs</term>
 	<listitem>
 	  <para>
diff --git a/ctdb/doc/ctdbd.conf.5.xml b/ctdb/doc/ctdbd.conf.5.xml
index 149aa627f0..e316abb412 100644
--- a/ctdb/doc/ctdbd.conf.5.xml
+++ b/ctdb/doc/ctdbd.conf.5.xml
@@ -231,16 +231,6 @@
       </varlistentry>
 
       <varlistentry>
-	<term>CTDB_LOG_RINGBUF_SIZE=<parameter>NUM</parameter></term>
-	<listitem>
-	  <para>
-	    Default is 0.  Corresponds to
-	    <option>--log-ringbuf-size</option>.
-	  </para>
-	</listitem>
-      </varlistentry>
-
-      <varlistentry>
 	<term>CTDB_LVS_PUBLIC_IP=<parameter>IPADDR</parameter></term>
 	<listitem>
 	  <para>