diff options
| author | Andrew Tridgell <tridge@samba.org> | 2007-04-29 16:19:40 +0200 |
|---|---|---|
| committer | Andrew Tridgell <tridge@samba.org> | 2007-04-29 16:19:40 +0200 |
| commit | e21f69107f423f24f5407adb9323fb0bc8aa3f64 (patch) | |
| tree | f357af261e07dde8822d0d178f7906c7e1cc9b33 /ctdb/common/ctdb_control.c | |
| parent | 10910f52eb1e62bf5393952f4c3a7380bf2dc548 (diff) | |
| download | samba-e21f69107f423f24f5407adb9323fb0bc8aa3f64.tar.gz samba-e21f69107f423f24f5407adb9323fb0bc8aa3f64.tar.xz samba-e21f69107f423f24f5407adb9323fb0bc8aa3f64.zip | |
yay! finally fixed the bug that volker, ronnie and I have been chasing
for 2 days.
The main bug was in smbd, but there was a secondary (and more subtle)
bug in ctdb that the bug in smbd exposed. When we get send a dmaster
reply, we have to correctly update the dmaster in the recipient even
if the original requst has timed out, otherwise ctdbd can get into a
loop fighting over who will handle a key.
This patch also cleans up the packet allocation, and makes ctdbd
become a real daemon.
(This used to be ctdb commit 59405e59ef522b97d8e20e4b14310a217141ac7c)
Diffstat (limited to 'ctdb/common/ctdb_control.c')
| -rw-r--r-- | ctdb/common/ctdb_control.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ctdb/common/ctdb_control.c b/ctdb/common/ctdb_control.c index 306323cceb..b24c2686cc 100644 --- a/ctdb/common/ctdb_control.c +++ b/ctdb/common/ctdb_control.c @@ -248,6 +248,8 @@ void ctdb_reply_control(struct ctdb_context *ctdb, struct ctdb_req_header *hdr) state = ctdb_reqid_find(ctdb, hdr->reqid, struct ctdb_control_state); if (state == NULL) { + DEBUG(0,("vnn %u Invalid reqid %u in ctdb_reply_control\n", + ctdb->vnn, hdr->reqid)); return; } |