diff options
| author | Stefan Metzmacher <metze@samba.org> | 2014-08-26 23:11:39 +0200 |
|---|---|---|
| committer | Stefan Metzmacher <metze@samba.org> | 2014-09-05 19:47:05 +0200 |
| commit | da8c76354549a64181cffc36e1c0bb0c6c4f87d3 (patch) | |
| tree | 8a69a663b48c354acb8b89c4351d22c4ae581f4c /buildtools | |
| parent | ee8fbbd41741e958e0ab6d7b9ab465d664abac60 (diff) | |
| download | samba-da8c76354549a64181cffc36e1c0bb0c6c4f87d3.tar.gz samba-da8c76354549a64181cffc36e1c0bb0c6c4f87d3.tar.xz samba-da8c76354549a64181cffc36e1c0bb0c6c4f87d3.zip | |
wafsamba: fix dependency for SAMBA_GENERATOR() when passing vars!=None
vars can only be a dictionary as that's the only thing bld.EXPAND_VARIABLES()
accepts.
We need to checksum the whole vars dictionary into the dependencies.
We set task.env.SAMBA_GENERATOR_VARS = vars and add SAMBA_GENERATOR_VARS
to the dep_vars.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10472
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Diffstat (limited to 'buildtools')
| -rw-r--r-- | buildtools/wafsamba/wafsamba.py | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/buildtools/wafsamba/wafsamba.py b/buildtools/wafsamba/wafsamba.py index ba34fe5400..ce391a2375 100644 --- a/buildtools/wafsamba/wafsamba.py +++ b/buildtools/wafsamba/wafsamba.py @@ -599,11 +599,8 @@ def SAMBA_GENERATOR(bld, name, rule, source='', target='', return dep_vars = [] - if isinstance(vars, dict): - dep_vars = vars.keys() - elif isinstance(vars, list): - dep_vars = vars dep_vars.append('ruledeps') + dep_vars.append('SAMBA_GENERATOR_VARS') bld.SET_BUILD_GROUP(group) t = bld( @@ -618,6 +615,10 @@ def SAMBA_GENERATOR(bld, name, rule, source='', target='', dep_vars = dep_vars, name=name) + if vars is None: + vars = {} + t.env.SAMBA_GENERATOR_VARS = vars + if always: t.always = True |