summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2014-02-27 09:59:51 +0100
committerStefan Metzmacher <metze@samba.org>2014-08-26 09:13:06 +0200
commitfbebe7e756e4ccd0684e94e9b1e787f98f399ccc (patch)
tree33e762db3c50e1dbe49369605dcd5d2c0fbd7a29
parent491715399ff7e1ab788fec5e254581dc312e2cef (diff)
downloadsamba-fbebe7e756e4ccd0684e94e9b1e787f98f399ccc.tar.gz
samba-fbebe7e756e4ccd0684e94e9b1e787f98f399ccc.tar.xz
samba-fbebe7e756e4ccd0684e94e9b1e787f98f399ccc.zip
s4:dlz_bind9: avoid some compiler warnings
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
-rw-r--r--source4/dns_server/dlz_bind9.c6
-rw-r--r--source4/dns_server/dlz_minimal.h2
-rw-r--r--source4/torture/dns/dlz_bind9.c7
3 files changed, 8 insertions, 7 deletions
diff --git a/source4/dns_server/dlz_bind9.c b/source4/dns_server/dlz_bind9.c
index 3ffb06b3ef..092f2557c8 100644
--- a/source4/dns_server/dlz_bind9.c
+++ b/source4/dns_server/dlz_bind9.c
@@ -466,7 +466,7 @@ static isc_result_t b9_putnamedrr(struct dlz_bind9_data *state,
parse options
*/
static isc_result_t parse_options(struct dlz_bind9_data *state,
- unsigned int argc, char *argv[],
+ unsigned int argc, const char **argv,
struct b9_options *options)
{
int opt;
@@ -477,7 +477,7 @@ static isc_result_t parse_options(struct dlz_bind9_data *state,
{ NULL }
};
- pc = poptGetContext("dlz_bind9", argc, (const char **)argv, long_options,
+ pc = poptGetContext("dlz_bind9", argc, argv, long_options,
POPT_CONTEXT_KEEP_FIRST);
while ((opt = poptGetNextOpt(pc)) != -1) {
switch (opt) {
@@ -571,7 +571,7 @@ static int dlz_state_debug_unregister(struct dlz_bind9_data *state)
called to initialise the driver
*/
_PUBLIC_ isc_result_t dlz_create(const char *dlzname,
- unsigned int argc, char *argv[],
+ unsigned int argc, const char **argv,
void **dbdata, ...)
{
struct dlz_bind9_data *state;
diff --git a/source4/dns_server/dlz_minimal.h b/source4/dns_server/dlz_minimal.h
index 5262cbdaa6..98fb34e974 100644
--- a/source4/dns_server/dlz_minimal.h
+++ b/source4/dns_server/dlz_minimal.h
@@ -100,7 +100,7 @@ int dlz_version(unsigned int *flags);
/*
* dlz_create() is required for all DLZ external drivers.
*/
-isc_result_t dlz_create(const char *dlzname, unsigned int argc, char *argv[], void **dbdata, ...);
+isc_result_t dlz_create(const char *dlzname, unsigned int argc, const char **argv, void **dbdata, ...);
/*
* dlz_destroy() is optional, and will be called when the driver is
diff --git a/source4/torture/dns/dlz_bind9.c b/source4/torture/dns/dlz_bind9.c
index b7d6957bd6..0ee2f19aca 100644
--- a/source4/torture/dns/dlz_bind9.c
+++ b/source4/torture/dns/dlz_bind9.c
@@ -61,7 +61,7 @@ static bool test_dlz_bind9_create(struct torture_context *tctx)
NULL
};
tctx_static = tctx;
- torture_assert_int_equal(tctx, dlz_create("samba_dlz", 3, discard_const_p(char *, argv), &dbdata,
+ torture_assert_int_equal(tctx, dlz_create("samba_dlz", 3, argv, &dbdata,
"log", dlz_bind9_log_wrapper, NULL), ISC_R_SUCCESS,
"Failed to create samba_dlz");
@@ -109,7 +109,7 @@ static bool test_dlz_bind9_configure(struct torture_context *tctx)
NULL
};
tctx_static = tctx;
- torture_assert_int_equal(tctx, dlz_create("samba_dlz", 3, discard_const_p(char *, argv), &dbdata,
+ torture_assert_int_equal(tctx, dlz_create("samba_dlz", 3, argv, &dbdata,
"log", dlz_bind9_log_wrapper,
"writeable_zone", dlz_bind9_writeable_zone_hook, NULL),
ISC_R_SUCCESS,
@@ -144,7 +144,7 @@ static bool test_dlz_bind9_gensec(struct torture_context *tctx, const char *mech
NULL
};
tctx_static = tctx;
- torture_assert_int_equal(tctx, dlz_create("samba_dlz", 3, discard_const_p(char *, argv), &dbdata,
+ torture_assert_int_equal(tctx, dlz_create("samba_dlz", 3, argv, &dbdata,
"log", dlz_bind9_log_wrapper,
"writeable_zone", dlz_bind9_writeable_zone_hook, NULL),
ISC_R_SUCCESS,
@@ -216,6 +216,7 @@ static struct torture_suite *dlz_bind9_suite(TALLOC_CTX *ctx)
/**
* DNS torture module initialization
*/
+NTSTATUS torture_bind_dns_init(void);
NTSTATUS torture_bind_dns_init(void)
{
struct torture_suite *suite;