summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHar Gagan Sahai <SHarGagan@novell.com>2014-08-06 14:32:35 +0530
committerJeremy Allison <jra@samba.org>2014-08-13 04:36:49 +0200
commitf34ffd0d0993f997f2b4e3b992338def367cc49b (patch)
treecbface5d22d826e625374ada9d3689e1dc5cc61a
parentc2f66e71aaf6f31f177ea53686cf30438e292b23 (diff)
downloadsamba-f34ffd0d0993f997f2b4e3b992338def367cc49b.tar.gz
samba-f34ffd0d0993f997f2b4e3b992338def367cc49b.tar.xz
samba-f34ffd0d0993f997f2b4e3b992338def367cc49b.zip
Fixed a memory leak in cli_set_mntpoint().
Fixes bug #10759 - Memory leak in libsmbclient in cli_set_mntpoint function https://bugzilla.samba.org/show_bug.cgi?id=10759 Signed-off-by: Har Gagan Sahai <SHarGagan@novell.com> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed Aug 13 04:36:50 CEST 2014 on sn-devel-104
-rw-r--r--source3/libsmb/clidfs.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/source3/libsmb/clidfs.c b/source3/libsmb/clidfs.c
index 80fba23f67..93f04c5074 100644
--- a/source3/libsmb/clidfs.c
+++ b/source3/libsmb/clidfs.c
@@ -280,13 +280,15 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
static void cli_set_mntpoint(struct cli_state *cli, const char *mnt)
{
- char *name = clean_name(NULL, mnt);
+ TALLOC_CTX *frame = talloc_stackframe();
+ char *name = clean_name(frame, mnt);
if (!name) {
+ TALLOC_FREE(frame);
return;
}
TALLOC_FREE(cli->dfs_mountpoint);
cli->dfs_mountpoint = talloc_strdup(cli, name);
- TALLOC_FREE(name);
+ TALLOC_FREE(frame);
}
/********************************************************************