summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2014-12-19 16:02:40 +1300
committerGarming Sam <garming@samba.org>2014-12-22 02:42:42 +0100
commit7cfe6e91177e93f80d4d7e02d1414ca80641e13c (patch)
treeeedebdb6fd195c51b4c9f3a1412bf9d7a3f8d4a2
parent1a012d591bca727b5cabacf6455d2009afb16bd7 (diff)
downloadsamba-7cfe6e91177e93f80d4d7e02d1414ca80641e13c.tar.gz
samba-7cfe6e91177e93f80d4d7e02d1414ca80641e13c.tar.xz
samba-7cfe6e91177e93f80d4d7e02d1414ca80641e13c.zip
lib/ldb-samba: Add comment dicouraging use of schemaUpgradeInProgress
Signed-off-by: Garming Sam <garming@catalyst.net.nz> Pair-programmed-with: Garming Sam <garming@catalyst.net.nz> Signed-off-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Garming Sam <garming@samba.org> Autobuild-Date(master): Mon Dec 22 02:42:42 CET 2014 on sn-devel-104
-rwxr-xr-xlib/ldb-samba/tests/match_rules.py10
1 files changed, 10 insertions, 0 deletions
diff --git a/lib/ldb-samba/tests/match_rules.py b/lib/ldb-samba/tests/match_rules.py
index cb18248f16..6b31392df1 100755
--- a/lib/ldb-samba/tests/match_rules.py
+++ b/lib/ldb-samba/tests/match_rules.py
@@ -209,6 +209,16 @@ class MatchRulesTests(samba.tests.TestCase):
# |-> c1
# | |->c2
# | | |->u1
+
+ #
+ # While appropriate for this test, this is NOT a good practice
+ # in general. This is only done here because the alternative
+ # is to make a schema modification.
+ #
+ # IF/WHEN Samba protects this attribute better, this
+ # particular part of the test can be removed, as the same code
+ # is covered by the addressBookRoots2 case well enough.
+ #
m = Message()
m.dn = Dn(self.ldb, "")
m["e1"] = MessageElement("1", FLAG_MOD_REPLACE, "schemaUpgradeInProgress")