summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Schwenke <martin@meltin.net>2014-07-30 21:10:01 +1000
committerAmitay Isaacs <amitay@samba.org>2014-08-21 04:46:13 +0200
commit2807b185f438c40544d4fd133bc386e411b12d0c (patch)
tree339728152465cc80ddc16c4b1eb5c1f4eefa3717
parentc1558adeaa980fb4bd6177d36250ec8262e9b9fe (diff)
downloadsamba-2807b185f438c40544d4fd133bc386e411b12d0c.tar.gz
samba-2807b185f438c40544d4fd133bc386e411b12d0c.tar.xz
samba-2807b185f438c40544d4fd133bc386e411b12d0c.zip
ctdb-util: Fix warning about ignored result from system()
Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
-rw-r--r--ctdb/common/ctdb_util.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/ctdb/common/ctdb_util.c b/ctdb/common/ctdb_util.c
index c4ac583b99..b16e9cc42a 100644
--- a/ctdb/common/ctdb_util.c
+++ b/ctdb/common/ctdb_util.c
@@ -73,7 +73,7 @@ void ctdb_die(struct ctdb_context *ctdb, const char *msg)
*/
void ctdb_external_trace(void)
{
-
+ int ret;
const char * t = getenv("CTDB_EXTERNAL_TRACE");
char * cmd;
@@ -83,7 +83,11 @@ void ctdb_external_trace(void)
cmd = talloc_asprintf(NULL, "%s %lu", t, (unsigned long) getpid());
DEBUG(DEBUG_WARNING,("begin external trace: %s\n", cmd));
- system(cmd);
+ ret = system(cmd);
+ if (ret == -1) {
+ DEBUG(DEBUG_ERR,
+ ("external trace command \"%s\" failed\n", cmd));
+ }
DEBUG(DEBUG_WARNING,("end external trace: %s\n", cmd));
talloc_free(cmd);
}