summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJames Shubin <james@shubin.ca>2013-09-18 05:57:28 -0400
committerJames Shubin <james@shubin.ca>2013-09-18 05:57:28 -0400
commit99b5c5c16751a2b459ea31d7fe98aa68be9f0eb7 (patch)
tree9e2e35186ebab8b20c23b5460baf6ba6c1674ced
parentb3a75df1e1be24e65ffc8dc70577803cdb700f56 (diff)
Misc comments.
-rw-r--r--manifests/host.pp1
-rw-r--r--manifests/volume.pp1
2 files changed, 2 insertions, 0 deletions
diff --git a/manifests/host.pp b/manifests/host.pp
index 390b4c4..e3a12c4 100644
--- a/manifests/host.pp
+++ b/manifests/host.pp
@@ -196,6 +196,7 @@ define gluster::host(
}
# TODO: is this only used for nfs?
+ # TODO: johnmark says gluster nfs udp doesn't work :P
@@shorewall::rule { "gluster-udp111-${name}":
action => 'ACCEPT',
source => "${zone}", # override this on collect...
diff --git a/manifests/volume.pp b/manifests/volume.pp
index 0873ad4..8623897 100644
--- a/manifests/volume.pp
+++ b/manifests/volume.pp
@@ -111,6 +111,7 @@ define gluster::volume(
# because it shouldn't work until all the bricks are available,
# which per node will happen right before this runs.
# fping all the other nodes to ensure they're up for creation
+ # TODO: consider piping in a /usr/bin/yes to avoid warnings...
# EXAMPLE: gluster volume create test replica 2 transport tcp annex1.example.com:/storage1a/test annex2.example.com:/storage2a/test annex3.example.com:/storage3b/test annex4.example.com:/storage4b/test annex1.example.com:/storage1c/test annex2.example.com:/storage2c/test annex3.example.com:/storage3d/test annex4.example.com:/storage4d/test
exec { "/usr/sbin/gluster volume create ${name} ${valid_replica}${valid_stripe}transport ${valid_transport} ${brick_spec}":
logoutput => on_failure,