summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPavel Březina <pbrezina@redhat.com>2016-10-14 12:19:54 +0200
committerLukas Slebodnik <lslebodn@redhat.com>2016-12-19 23:26:22 +0100
commit87d85db07bdd39081f558e2f7e891cc0065e3a0a (patch)
tree64eed077ef6e5089ddbc54161545b2dc2f29af5c /src
parent0713b92ec9f10b6dd913dc56cbc7845d1b025ccb (diff)
responders: remove checks that are handled inside cache_req
Those checks were redundant, since they are already part of cache_req. Resolves: https://fedorahosted.org/sssd/ticket/3151 Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
Diffstat (limited to 'src')
-rw-r--r--src/responder/nss/nsssrv_cmd.c5
-rw-r--r--src/responder/pac/pacsrv_cmd.c8
-rw-r--r--src/responder/pam/pamsrv_cmd.c7
3 files changed, 1 insertions, 19 deletions
diff --git a/src/responder/nss/nsssrv_cmd.c b/src/responder/nss/nsssrv_cmd.c
index 0352ff348..062a1f339 100644
--- a/src/responder/nss/nsssrv_cmd.c
+++ b/src/responder/nss/nsssrv_cmd.c
@@ -5418,10 +5418,7 @@ static void users_find_by_cert_done(struct tevent_req *req)
ret = cache_req_user_by_cert_recv(cctx, req, &result);
talloc_zfree(req);
- if (ret == ENOENT || result->count == 0) {
- ret = ENOENT;
- goto done;
- } else if (ret != EOK) {
+ if (ret != EOK) {
goto done;
}
diff --git a/src/responder/pac/pacsrv_cmd.c b/src/responder/pac/pacsrv_cmd.c
index ddb8c0c90..e3aab8886 100644
--- a/src/responder/pac/pacsrv_cmd.c
+++ b/src/responder/pac/pacsrv_cmd.c
@@ -238,14 +238,6 @@ static void pac_resolve_user_sid_done(struct tevent_req *req)
return;
}
- if (result->count != 1) {
- DEBUG(SSSDBG_CRIT_FAILURE,
- "Expected only 1 result for SID lookup, got [%ud].\n",
- result->count);
- ret = EINVAL;
- goto done;
- }
-
user_attrs = sysdb_new_attrs(pr_ctx);
if (user_attrs == NULL) {
DEBUG(SSSDBG_OP_FAILURE, "sysdb_new_attrs failed.\n");
diff --git a/src/responder/pam/pamsrv_cmd.c b/src/responder/pam/pamsrv_cmd.c
index ca4c37605..e73a81906 100644
--- a/src/responder/pam/pamsrv_cmd.c
+++ b/src/responder/pam/pamsrv_cmd.c
@@ -1431,13 +1431,6 @@ static void pam_forwarder_lookup_by_cert_done(struct tevent_req *req)
goto done;
}
- if (ret == EOK && result->count > 1) {
- DEBUG(SSSDBG_CRIT_FAILURE,
- "Search by certificate returned more than one result.\n");
- ret = EINVAL;
- goto done;
- }
-
if (ret == EOK) {
if (preq->domain == NULL) {
preq->domain = result->domain;