diff options
author | Lukas Slebodnik <lslebodn@redhat.com> | 2016-07-25 09:11:08 +0200 |
---|---|---|
committer | Lukas Slebodnik <lslebodn@redhat.com> | 2016-07-25 15:49:20 +0200 |
commit | bc7991db97482eb2ac77f7105ee4bb3d329acff7 (patch) | |
tree | 4c3b29cb36518cc8faa3b97d39841cabfc3017b4 /src/tools | |
parent | 66588a6241df42a04cb9ead75cf3afb38495d74a (diff) | |
download | sssd-bc7991db97482eb2ac77f7105ee4bb3d329acff7.tar.gz sssd-bc7991db97482eb2ac77f7105ee4bb3d329acff7.tar.xz sssd-bc7991db97482eb2ac77f7105ee4bb3d329acff7.zip |
Amend debug messages after failure of unlink
Some messages did not have errno or name of problematic file.
There was also improper use of negative value.
The function strerror was called with -1 instead of errno
Reviewed-by: Petr Čech <pcech@redhat.com>
Diffstat (limited to 'src/tools')
-rw-r--r-- | src/tools/files.c | 3 | ||||
-rw-r--r-- | src/tools/tools_mc_util.c | 7 |
2 files changed, 6 insertions, 4 deletions
diff --git a/src/tools/files.c b/src/tools/files.c index 5364f5c0d..8f1aa68be 100644 --- a/src/tools/files.c +++ b/src/tools/files.c @@ -225,7 +225,8 @@ static int remove_tree_with_ctx(TALLOC_CTX *mem_ctx, if (ret != 0) { ret = errno; DEBUG(SSSDBG_CRIT_FAILURE, - "Removing file failed: [%d][%s]\n", ret, strerror(ret)); + "Removing file failed '%s': [%d][%s]\n", + result->d_name, ret, strerror(ret)); goto fail; } } diff --git a/src/tools/tools_mc_util.c b/src/tools/tools_mc_util.c index ce899eb3c..2516a1981 100644 --- a/src/tools/tools_mc_util.c +++ b/src/tools/tools_mc_util.c @@ -117,10 +117,11 @@ done: if (ret == EOK) { pret = unlink(mc_filename); if (pret == -1) { + pret = errno; DEBUG(SSSDBG_MINOR_FAILURE, - "Failed to unlink file %s. " - "Will be unlinked later by sssd_nss.\n", - mc_filename); + "Failed to unlink file %s, %d [%s]. " + "Will be unlinked later by sssd_nss.\n", + mc_filename, pret, strerror(pret)); } } } |