diff options
| author | Pavel Březina <pbrezina@redhat.com> | 2016-11-24 13:12:17 +0100 |
|---|---|---|
| committer | Lukas Slebodnik <lslebodn@redhat.com> | 2016-12-19 23:24:18 +0100 |
| commit | 817e3ec31bbdb5447f4ffcd3302c558283b90943 (patch) | |
| tree | de331c37739dfea35422e7464a794a756d4dacf0 /src/responder/common/cache_req | |
| parent | 8f895983e8d24b3edde4f695621f6b9a2fd20923 (diff) | |
| download | sssd-817e3ec31bbdb5447f4ffcd3302c558283b90943.tar.gz sssd-817e3ec31bbdb5447f4ffcd3302c558283b90943.tar.xz sssd-817e3ec31bbdb5447f4ffcd3302c558283b90943.zip | |
cache_req: improve debugging
The original debugging was unnecessarily large. I removed request name
from all debug messages (keeping the request number). The name is now
print only when a new request is created. I also added an explicit message
to see what object are we currently looking up.
For example:
[cache_req_set_plugin] (0x2000): CR #4: Setting "Group by ID" plugin
[cache_req_send] (0x0400): CR #4: New request 'Group by ID'
[cache_req_select_domains] (0x0400): CR #4: Performing a multi-domain search
[cache_req_set_domain] (0x0400): CR #4: Using domain [LDAP.PB]
[cache_req_search_send] (0x0400): CR #4: Looking up GID:20001@LDAP.PB
[cache_req_search_ncache] (0x0400): CR #4: Checking negative cache for [GID:20001@LDAP.PB]
[cache_req_search_ncache] (0x0400): CR #4: [GID:20001@LDAP.PB] is not present in negative cache
[cache_req_search_cache] (0x0400): CR #4: Looking up [GID:20001@LDAP.PB] in cache
[cache_req_search_send] (0x0400): CR #4: Returning [GID:20001@LDAP.PB] from cache
[cache_req_create_and_add_result] (0x0400): CR #4: Found 1 entries in domain LDAP.PB
[cache_req_done] (0x0400): CR #4: Finished: Success
Resolves:
https://fedorahosted.org/sssd/ticket/3151
Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
Diffstat (limited to 'src/responder/common/cache_req')
| -rw-r--r-- | src/responder/common/cache_req/cache_req.c | 2 | ||||
| -rw-r--r-- | src/responder/common/cache_req/cache_req_private.h | 3 | ||||
| -rw-r--r-- | src/responder/common/cache_req/cache_req_search.c | 2 |
3 files changed, 4 insertions, 3 deletions
diff --git a/src/responder/common/cache_req/cache_req.c b/src/responder/common/cache_req/cache_req.c index 4cc28c096..3a37d652b 100644 --- a/src/responder/common/cache_req/cache_req.c +++ b/src/responder/common/cache_req/cache_req.c @@ -363,7 +363,7 @@ struct tevent_req *cache_req_send(TALLOC_CTX *mem_ctx, goto done; } - CACHE_REQ_DEBUG(SSSDBG_TRACE_FUNC, cr, "New request\n"); + CACHE_REQ_DEBUG(SSSDBG_TRACE_FUNC, cr, "New request '%s'\n", cr->reqname); ret = cache_req_is_well_known_object(state, cr, &result); if (ret == EOK) { diff --git a/src/responder/common/cache_req/cache_req_private.h b/src/responder/common/cache_req/cache_req_private.h index 9a2ab66ad..978389a93 100644 --- a/src/responder/common/cache_req/cache_req_private.h +++ b/src/responder/common/cache_req/cache_req_private.h @@ -27,8 +27,7 @@ #include "responder/common/cache_req/cache_req.h" #define CACHE_REQ_DEBUG(level, cr, fmt, ...) \ - DEBUG(level, "CR [%s #%u]: " fmt, \ - (cr)->reqname, (cr)->reqid, ##__VA_ARGS__) + DEBUG(level, "CR #%u: " fmt, (cr)->reqid, ##__VA_ARGS__) struct cache_req { /* Provided input. */ diff --git a/src/responder/common/cache_req/cache_req_search.c b/src/responder/common/cache_req/cache_req_search.c index 58edcd42c..2f8234029 100644 --- a/src/responder/common/cache_req/cache_req_search.c +++ b/src/responder/common/cache_req/cache_req_search.c @@ -253,6 +253,8 @@ cache_req_search_send(TALLOC_CTX *mem_ctx, return NULL; } + CACHE_REQ_DEBUG(SSSDBG_TRACE_FUNC, cr, "Looking up %s\n", cr->debugobj); + state->ev = ev; state->cr = cr; |