diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2014-02-26 09:45:46 +0100 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-02-26 19:29:26 +0100 |
| commit | cfaa16fe871f10f5bba0a55beb39e8223dbdf001 (patch) | |
| tree | 48b87ab3405b0532fd7ee01bec0661149e2970ee /src/providers/krb5/krb5_common.c | |
| parent | 3dfa09a826e5f63b4948462c2452937fc329834d (diff) | |
| download | sssd-cfaa16fe871f10f5bba0a55beb39e8223dbdf001.tar.gz sssd-cfaa16fe871f10f5bba0a55beb39e8223dbdf001.tar.xz sssd-cfaa16fe871f10f5bba0a55beb39e8223dbdf001.zip | |
KRB5: Fix condition for empty string
Reported by: cppcheck
Finding the same expression on both sides of an operator || is suspicious and
might indicate a cut and paste or logic error.
Resolves:
https://fedorahosted.org/sssd/ticket/2258
Reviewed-by: Michal Žídek <mzidek@redhat.com>
Diffstat (limited to 'src/providers/krb5/krb5_common.c')
| -rw-r--r-- | src/providers/krb5/krb5_common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/providers/krb5/krb5_common.c b/src/providers/krb5/krb5_common.c index 3d0fc0bfa..bf7b1f0e0 100644 --- a/src/providers/krb5/krb5_common.c +++ b/src/providers/krb5/krb5_common.c @@ -422,7 +422,7 @@ errno_t write_krb5info_file(const char *realm, const char *server, mode_t old_umask; if (realm == NULL || *realm == '\0' || server == NULL || *server == '\0' || - service == NULL || service == '\0') { + service == NULL || *service == '\0') { DEBUG(SSSDBG_CRIT_FAILURE, "Missing or empty realm, server or service.\n"); return EINVAL; |